[PATCH 00/34]bnx2x: Bug fixes

[PATCH 00/34]bnx2x: Bug fixes

[Eilon Greenstein]

Hi Dave,

While developing new features and testing them on different platforms,
bugs were discovered. It took a while to get a clean version and to
identify which of the bugs are relevant to the existing published
version (as apposed to bugs that were introduced with the new features).
The problem is that more and more bugs required immediate attention so
the result is a long list of bug fixes.

I hope that in the future I will have enough space between bugs to allow
sending each fix when found. But today, I have a long list...

Please consider applying.

Thanks,
Eilon

Re: [PATCH 00/34]bnx2x: Bug fixes

[David Miller]

From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Wed, 14 Jan 2009 18:42:35 +0200

> The problem is that more and more bugs required immediate attention so
> the result is a long list of bug fixes.

You have to understand that you absolutely cannot slap me with 34 "bug
fixes" all at once after the merge window is closed.

> Please consider applying.

I've gone through patches 1 to 17 for now.  Patched I didn't apply:

1) [PATCH 02/34]bnx2x: Barriers for the compiler

   Need feedback on my query, if this requires a compiler barrier
   it almost certainly needs cpu reordering barriers too.

2) [PATCH 05/34]bnx2x: Setting the GSO_TYPE with LRO

   As discussed at length, this isn't correct and it's not the
   way to fix this problem.  Implement the ethtool LRO disable
   and the kernel will turn it off when bridging or routing is
   being used over this interface.

3) [PATCH 10/34]bnx2x: Compilation issue on IA64

   This code is ugly and even in the worst case the thing to do
   is unconditionally use "%llx" and cast the arg to "long long"
   to kill the warning.

4) [PATCH 13/34]bnx2x: System cache alignment

   This is an optimization and has no business going in outside
   of the merge window.

I'll go over the rest after I send what I have now to Linus, but don't
set your expectations high, this is way too many patches to be sending
now.

Re: [PATCH 00/34]bnx2x: Bug fixes

[Eilon Greenstein]

On Wed, 2009-01-14 at 21:36 -0800, David Miller wrote:

> I've gone through patches 1 to 17 for now.  Patched I didn't apply:
> 
> 1) [PATCH 02/34]bnx2x: Barriers for the compiler
> 
>    Need feedback on my query, if this requires a compiler barrier
>    it almost certainly needs cpu reordering barriers too.

I still believe it is in place, please see my response

> I'll go over the rest after I send what I have now to Linus, but don't
> set your expectations high, this is way too many patches to be sending
> now.

As long as it is in your queue, I still have hope...

Thanks,
Eilon