Netdev List
 help / color / mirror / Atom feed
* [PATCH 2/4]bnx2x: Missing rmb when waiting for FW response
@ 2009-01-22 16:01 Eilon Greenstein
  0 siblings, 0 replies; only message in thread
From: Eilon Greenstein @ 2009-01-22 16:01 UTC (permalink / raw)
  To: David Miller; +Cc: Harvey Harrison, Michal Kalderon, netdev

Waiting for the FW to response requires a memory barrier

Signed-off-by: Michal Kalderon <michals@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
 drivers/net/bnx2x_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index 71fbf2d..f71b8a5 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -6622,6 +6622,7 @@ static int bnx2x_stop_leading(struct bnx2x *bp)
 		}
 		cnt--;
 		msleep(1);
+		rmb(); /* Refresh the dsb_sp_prod */
 	}
 	bp->state = BNX2X_STATE_CLOSING_WAIT4_UNLOAD;
 	bp->fp[0].state = BNX2X_FP_STATE_CLOSED;
-- 
1.5.4.3





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-01-22 16:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-22 16:01 [PATCH 2/4]bnx2x: Missing rmb when waiting for FW response Eilon Greenstein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox