From: "Eilon Greenstein" <eilong@broadcom.com>
To: "Harvey Harrison" <harvey.harrison@gmail.com>
Cc: linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/9] bnx2x: remove a few trivial macros
Date: Thu, 22 Jan 2009 19:49:06 +0200 [thread overview]
Message-ID: <1232646546.29087.84.camel@lb-tlvb-eliezer> (raw)
In-Reply-To: <1232517046.9701.19.camel@brick>
On Tue, 2009-01-20 at 21:50 -0800, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Eilon, after this series, sparse with endian-checking at least gets through a
> compile without hitting too many errors, patch 9 is a functional change
> and may have exposed an endian bug in the driver....but I had to get through
> the other 8 to see it ;-)
>
> patches 1-8 shouldn't change any behavior...if it does it wasn't intentional.
>
> drivers/net/bnx2x.h | 4 ---
> drivers/net/bnx2x_main.c | 62 +++++++++++++++++++++++-----------------------
> 2 files changed, 31 insertions(+), 35 deletions(-)
Thanks Harvey! This change looks good
Acked-by: Eilon Greenstein <eilong@broadcom.com>
prev parent reply other threads:[~2009-01-22 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 5:50 [PATCH 1/9] bnx2x: remove a few trivial macros Harvey Harrison
2009-01-21 7:14 ` Eilon Greenstein
2009-01-21 23:42 ` David Miller
2009-01-22 17:50 ` Eilon Greenstein
2009-01-22 17:49 ` Eilon Greenstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232646546.29087.84.camel@lb-tlvb-eliezer \
--to=eilong@broadcom.com \
--cc=harvey.harrison@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox