Re: [PATCH 1/9] bnx2x: remove a few trivial macros

["Eilon Greenstein" <eilong@broadcom.com>]

On Wed, 2009-01-21 at 15:42 -0800, David Miller wrote:
> From: "Eilon Greenstein" <eilong@broadcom.com>
> Date: Wed, 21 Jan 2009 09:14:53 +0200
> 
> > On Tue, 2009-01-20 at 21:50 -0800, Harvey Harrison wrote:
> > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > > ---
> > > Eilon, after this series, sparse with endian-checking at least gets through a
> > > compile without hitting too many errors, patch 9 is a functional change
> > > and may have exposed an endian bug in the driver....but I had to get through
> > > the other 8 to see it ;-)
> > > 
> > Wooh!!! Harvey - thanks for all the hard work!
> > 
> > I will review it carefully and start regression tests on few different
> > platforms to verify this fix. Stay tuned.
> 
> Thanks Eilon, once you've validated these changes let me know
> so I can add them to net-next-2.6
> 

Besides the eeprom changes that broke a utility that uses it, this patch
is working just fine. I have few cosmetic issues with le_to_cpu for zero
(which I plan to remove) and I'm not sure if replacing swab with
cpu_to_le on top of be_to_cpu is the way to go - I hope to get some
comments on this one.

Harvey - I truly appreciate your work. I will pack it and resend it
after receiving some comments.

Thanks again,
Eilon