Netdev List
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: "Rao, Nikhil" <nikhirao@amd.com>, <netdev@vger.kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Brett Creeley <brett.creeley@amd.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Joyner <eric.joyner@amd.com>
Subject: Re: [PATCH net-next v3 0/6] pds_core: Add PLDM firmware update and host backed memory support
Date: Thu, 11 Jun 2026 11:53:13 -0700	[thread overview]
Message-ID: <1264de6d-a669-4afa-ad08-594d956e101a@intel.com> (raw)
In-Reply-To: <9e0a17e1-006d-473a-adff-ab76bf91d0ab@amd.com>

On 6/11/2026 10:15 AM, Rao, Nikhil wrote:
>>>> Vendor-specific component names
>>>
>>> Compliant with devlink-info.rst. Driver-specific component names are
>>> allowed when documented. These are documented in
>>> Documentation/networking/devlink/pds_core.rst.
>>>
>>
>> The preference is to use generic names when possible/feasible. I think
>> at least some of your name choices could align with the generic ones.
>>
>> Could you explain why fw.mainfw was selected and fw.mgmt was deemed not
>> suitable?
> 
> This component handles both control and data path, so fw.mgmt didn't
> feel right since devlink-info.rst explicitly excludes data path from
> that definition. We went with fw.mainfw to indicate it's the primary
> firmware component
> 
> Nikhil

It might make sense to extend or add a new definition in this case.
Technically you could also report both fw.mgmt and fw.app together, but
I think that would be more confusing.

Perhaps Jakub has a suggestion on the name or policy here. The
maintainer preference has generally been to use or extend standardized
names first unless the name or component is clearly unique to the device.

      reply	other threads:[~2026-06-11 18:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 22:32 [PATCH net-next v3 0/6] pds_core: Add PLDM firmware update and host backed memory support Nikhil P. Rao
2026-06-08 22:32 ` [PATCH v3 1/6] pds_core: add support for quiet devcmd failures Nikhil P. Rao
2026-06-08 22:32 ` [PATCH v3 2/6] pds_core: add support for identity version 2 Nikhil P. Rao
2026-06-08 22:32 ` [PATCH v3 3/6] pds_core: add PLDM firmware update support via devlink flash Nikhil P. Rao
2026-06-08 22:53   ` Jacob Keller
2026-06-08 22:32 ` [PATCH v3 4/6] pds_core: add PLDM component info display Nikhil P. Rao
2026-06-08 22:32 ` [PATCH v3 5/6] pds_core: add host backed memory support for firmware Nikhil P. Rao
2026-06-08 22:32 ` [PATCH v3 6/6] pds_core: add debugfs support for host backed memory Nikhil P. Rao
2026-06-11  1:14 ` [PATCH net-next v3 0/6] pds_core: Add PLDM firmware update and host backed memory support Rao, Nikhil
2026-06-11 15:56   ` Jacob Keller
2026-06-11 17:15     ` Rao, Nikhil
2026-06-11 18:53       ` Jacob Keller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264de6d-a669-4afa-ad08-594d956e101a@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=brett.creeley@amd.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.joyner@amd.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikhirao@amd.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox