Re: [PATCH net-next v3 0/6] pds_core: Add PLDM firmware update and host backed memory support

["Rao, Nikhil" <nikhirao@amd.com>]

On 6/11/2026 8:56 AM, Jacob Keller wrote:
> On 6/10/2026 6:14 PM, Rao, Nikhil wrote:
>>> extack never propagated through PLDM update path
>>
>> Valid observation. The PLDM update path returns errno but doesn't
>> populate extack with detailed messages. Usability improvement, not a
>> functional bug.
>>
> 
> If this requires updates to the pldmfw core, I'm happy to review and
> accept improvements there.

Thanks, but this is a driver issue the PLDM callbacks don't call 
NL_SET_ERR_MSG_MOD(). I will send a follow-up.

>>> Vendor-specific component names
>>
>> Compliant with devlink-info.rst. Driver-specific component names are
>> allowed when documented. These are documented in
>> Documentation/networking/devlink/pds_core.rst.
>>
> 
> The preference is to use generic names when possible/feasible. I think
> at least some of your name choices could align with the generic ones.
> 
> Could you explain why fw.mainfw was selected and fw.mgmt was deemed not
> suitable?

This component handles both control and data path, so fw.mgmt didn't 
feel right since devlink-info.rst explicitly excludes data path from 
that definition. We went with fw.mainfw to indicate it's the primary 
firmware component

Nikhil