From: jamal <hadi@cyberus.ca>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, Alexander Duyck <alexander.h.duyck@intel.com>
Subject: [PATCH iproute2]: skbedit: use get_u32 for parsing mark
Date: Mon, 15 Feb 2010 06:51:01 -0500 [thread overview]
Message-ID: <1266234661.6776.82.camel@bigi> (raw)
[-- Attachment #1: Type: text/plain, Size: 94 bytes --]
parsing a mark as a classid allows for acceptance of strange
informal input.
cheers,
jamal
[-- Attachment #2: skbedu32 --]
[-- Type: text/plain, Size: 734 bytes --]
commit aad0da6507ff8a95a63ed8e529c05f52be5b0e75
Author: Jamal Hadi Salim <hadi@cyberus.ca>
Date: Mon Feb 15 06:45:29 2010 -0500
skbedit: use get_u32 for parsing mark
get_u32 is the more appropriate parser for a mark.
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c
index 5d1a96a..990b9c7 100644
--- a/tc/m_skbedit.c
+++ b/tc/m_skbedit.c
@@ -86,7 +86,7 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
} else if (matches(*argv, "mark") == 0) {
flags |= SKBEDIT_F_MARK;
NEXT_ARG();
- if (get_tc_classid(&mark, *argv)) {
+ if (get_u32(&mark, *argv, 0)) {
fprintf(stderr, "Illegal mark\n");
return -1;
}
reply other threads:[~2010-02-15 11:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266234661.6776.82.camel@bigi \
--to=hadi@cyberus.ca \
--cc=alexander.h.duyck@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox