public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH iproute2]: skbedit: use get_u32 for parsing mark
@ 2010-02-15 11:51 jamal
  0 siblings, 0 replies; only message in thread
From: jamal @ 2010-02-15 11:51 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev, Alexander Duyck

[-- Attachment #1: Type: text/plain, Size: 94 bytes --]


parsing a mark as a classid allows for acceptance of strange
informal input.

cheers,
jamal


[-- Attachment #2: skbedu32 --]
[-- Type: text/plain, Size: 734 bytes --]

commit aad0da6507ff8a95a63ed8e529c05f52be5b0e75
Author: Jamal Hadi Salim <hadi@cyberus.ca>
Date:   Mon Feb 15 06:45:29 2010 -0500

    skbedit: use get_u32 for parsing mark
    
    get_u32 is the more appropriate parser for a mark.
    
    Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>

diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c
index 5d1a96a..990b9c7 100644
--- a/tc/m_skbedit.c
+++ b/tc/m_skbedit.c
@@ -86,7 +86,7 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
 		} else if (matches(*argv, "mark") == 0) {
 			flags |= SKBEDIT_F_MARK;
 			NEXT_ARG();
-			if (get_tc_classid(&mark, *argv)) {
+			if (get_u32(&mark, *argv, 0)) {
 				fprintf(stderr, "Illegal mark\n");
 				return -1;
 			}

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-02-15 11:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-15 11:51 [PATCH iproute2]: skbedit: use get_u32 for parsing mark jamal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox