[PATCH net-2.6 1/2] sfc: Fix sign of efx_mcdi_poll_reboot() error in efx_mcdi_poll()

[PATCH net-2.6 1/2] sfc: Fix sign of efx_mcdi_poll_reboot() error in efx_mcdi_poll()

[Ben Hutchings]

efx_mcdi_poll() uses positive error numbers, matching the MCDI
protocol.  It must negate the result of efx_mcdi_poll_reboot() which
returns the usual negative error numbers.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
 drivers/net/sfc/mcdi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/sfc/mcdi.c b/drivers/net/sfc/mcdi.c
index 9f035b9..f66b3da 100644
--- a/drivers/net/sfc/mcdi.c
+++ b/drivers/net/sfc/mcdi.c
@@ -127,7 +127,7 @@ static int efx_mcdi_poll(struct efx_nic *efx)
 	efx_dword_t reg;
 
 	/* Check for a reboot atomically with respect to efx_mcdi_copyout() */
-	rc = efx_mcdi_poll_reboot(efx);
+	rc = -efx_mcdi_poll_reboot(efx);
 	if (rc)
 		goto out;
 
-- 
1.6.2.5


-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: [PATCH net-2.6 1/2] sfc: Fix sign of efx_mcdi_poll_reboot() error in efx_mcdi_poll()

[David Miller]

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 19 Feb 2010 23:29:27 +0000

> efx_mcdi_poll() uses positive error numbers, matching the MCDI
> protocol.  It must negate the result of efx_mcdi_poll_reboot() which
> returns the usual negative error numbers.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

Applied.