From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH] bridge: per-cpu packet statistics
Date: Tue, 02 Mar 2010 08:43:52 +0100 [thread overview]
Message-ID: <1267515832.2843.7.camel@edumazet-laptop> (raw)
In-Reply-To: <20100301161658.5a61143b@nehalam>
Le lundi 01 mars 2010 à 16:16 -0800, Stephen Hemminger a écrit :
> +static void br_dev_free(struct net_device *dev)
> +{
> + struct net_bridge *br = netdev_priv(dev);
> +
> + free_percpu(br->stats);
> +}
> +
> void br_dev_setup(struct net_device *dev)
> {
> random_ether_addr(dev->dev_addr);
> ether_setup(dev);
>
> dev->netdev_ops = &br_netdev_ops;
> - dev->destructor = free_netdev;
> + dev->destructor = br_dev_free;
> SET_ETHTOOL_OPS(dev, &br_ethtool_ops);
Isnt free_netdev() missing after this change ?
next prev parent reply other threads:[~2010-03-02 7:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 0:16 [PATCH] bridge: per-cpu packet statistics Stephen Hemminger
2010-03-02 6:01 ` Eric Dumazet
2010-03-02 17:22 ` [Bridge] " Stephen Hemminger
2010-03-16 2:48 ` Herbert Xu
2010-03-02 7:43 ` Eric Dumazet [this message]
2010-03-02 7:51 ` Eric Dumazet
2010-03-02 9:02 ` Eric Dumazet
2010-03-02 17:23 ` [Bridge] " Stephen Hemminger
2010-03-16 2:51 ` Herbert Xu
2010-03-02 17:58 ` [PATCH] bridge: per-cpu packet statistics (v2) Stephen Hemminger
2010-03-02 18:06 ` Eric Dumazet
2010-03-02 23:32 ` [Bridge] [PATCH] bridge: per-cpu packet statistics (v3) Stephen Hemminger
2010-03-03 6:09 ` Eric Dumazet
2010-03-03 9:16 ` David Miller
2010-03-17 4:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267515832.2843.7.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox