From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH] bridge: per-cpu packet statistics
Date: Tue, 02 Mar 2010 08:51:42 +0100 [thread overview]
Message-ID: <1267516302.2843.12.camel@edumazet-laptop> (raw)
In-Reply-To: <20100301161658.5a61143b@nehalam>
Le lundi 01 mars 2010 à 16:16 -0800, Stephen Hemminger a écrit :
> --- a/net/bridge/br_if.c 2010-03-01 08:22:23.476657998 -0800
> +++ b/net/bridge/br_if.c 2010-03-01 15:30:47.733227819 -0800
> @@ -185,6 +185,12 @@ static struct net_device *new_bridge_dev
> br = netdev_priv(dev);
> br->dev = dev;
>
> + br->stats = alloc_percpu(sizeof(struct br_cpu_netstats));
> + if (!br->stats) {
> + free_netdev(dev);
> + return NULL;
> + }
> +
Strange... this should be :
nr->stats = alloc_percpu(struct br_cpu_netstats);
Or even better, ask percpu allocator an aligned chunk
(2 or 4 longs) instead of (1 long)
nr->stats = __alloc_percpu(sizeof(struct br_cpu_netstats),
4 * sizeof(long));
next prev parent reply other threads:[~2010-03-02 7:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 0:16 [PATCH] bridge: per-cpu packet statistics Stephen Hemminger
2010-03-02 6:01 ` Eric Dumazet
2010-03-02 17:22 ` [Bridge] " Stephen Hemminger
2010-03-16 2:48 ` Herbert Xu
2010-03-02 7:43 ` Eric Dumazet
2010-03-02 7:51 ` Eric Dumazet [this message]
2010-03-02 9:02 ` Eric Dumazet
2010-03-02 17:23 ` [Bridge] " Stephen Hemminger
2010-03-16 2:51 ` Herbert Xu
2010-03-02 17:58 ` [PATCH] bridge: per-cpu packet statistics (v2) Stephen Hemminger
2010-03-02 18:06 ` Eric Dumazet
2010-03-02 23:32 ` [Bridge] [PATCH] bridge: per-cpu packet statistics (v3) Stephen Hemminger
2010-03-03 6:09 ` Eric Dumazet
2010-03-03 9:16 ` David Miller
2010-03-17 4:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267516302.2843.12.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox