Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: netdev@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] ipv4: udp: fix short packet and bad checksum logging
Date: Thu, 06 May 2010 16:48:00 +0200	[thread overview]
Message-ID: <1273157280.2853.9.camel@edumazet-laptop> (raw)
In-Reply-To: <1273153475-32363-1-git-send-email-bjorn@mork.no>

Le jeudi 06 mai 2010 à 15:44 +0200, Bjørn Mork a écrit :
> commit 2783ef23 moved the initialisation of saddr and daddr after
> pskb_may_pull() to avoid a potential data corruption.  Unfortunately
> also placing it after the short packet and bad checksum error paths,
> where these variables are used for logging.  The result is bogus
> output like
> 
> [92238.389505] UDP: short packet: From 2.0.0.0:65535 23715/178 to 0.0.0.0:65535
> 
> Moving the saddr and daddr initialisation above the error paths, while still
> keeping it after the pskb_may_pull() to keep the fix from commit 2783ef23.
> 
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
> Cc: stable@kernel.org
> ---
>  net/ipv4/udp.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Well done :)

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

To be backported to 2.6.29 and up kernels ;)




  parent reply	other threads:[~2010-05-06 14:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06 13:44 [PATCH] ipv4: udp: fix short packet and bad checksum logging Bjørn Mork
2010-05-06 13:44 ` [PATCH] ipv6: udp: make short packet logging consistent with ipv4 Bjørn Mork
2010-05-06 14:49   ` Eric Dumazet
2010-05-07  4:50     ` David Miller
2010-05-06 14:48 ` Eric Dumazet [this message]
2010-05-07  4:48   ` [PATCH] ipv4: udp: fix short packet and bad checksum logging David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273157280.2853.9.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=bjorn@mork.no \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox