From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: udp: make short packet logging consistent with ipv4
Date: Thu, 06 May 2010 16:49:26 +0200 [thread overview]
Message-ID: <1273157366.2853.10.camel@edumazet-laptop> (raw)
In-Reply-To: <1273153475-32363-2-git-send-email-bjorn@mork.no>
Le jeudi 06 mai 2010 à 15:44 +0200, Bjørn Mork a écrit :
> Adding addresses and ports to the short packet log message,
> like ipv4/udp.c does it, makes these messages a lot more useful:
>
> [ 822.182450] UDPv6: short packet: From [2001:db8:ffb4:3::1]:47839 23715/178 to [2001:db8:ffb4:3:5054:ff:feff:200]:1234
>
> This requires us to drop logging in case pskb_may_pull() fails,
> which also is consistent with ipv4/udp.c
>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
> ---
> net/ipv6/udp.c | 11 ++++++++---
> 1 files changed, 8 insertions(+), 3 deletions(-)
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
next prev parent reply other threads:[~2010-05-06 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 13:44 [PATCH] ipv4: udp: fix short packet and bad checksum logging Bjørn Mork
2010-05-06 13:44 ` [PATCH] ipv6: udp: make short packet logging consistent with ipv4 Bjørn Mork
2010-05-06 14:49 ` Eric Dumazet [this message]
2010-05-07 4:50 ` David Miller
2010-05-06 14:48 ` [PATCH] ipv4: udp: fix short packet and bad checksum logging Eric Dumazet
2010-05-07 4:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273157366.2853.10.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bjorn@mork.no \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox