* [PATCH] tcp: use correct net ns in cookie_v4_check()
@ 2010-06-03 15:45 Eric Dumazet
2010-06-04 22:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2010-06-03 15:45 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Unless I am mistaken, this is a stable candidate.
(Found by code review, please double check)
Thanks
[PATCH] tcp: use correct net ns in cookie_v4_check()
Its better to make a route lookup in appropriate namespace.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
net/ipv4/syncookies.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/syncookies.c b/net/ipv4/syncookies.c
index 5c24db4..9f6b222 100644
--- a/net/ipv4/syncookies.c
+++ b/net/ipv4/syncookies.c
@@ -347,7 +347,7 @@ struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb,
{ .sport = th->dest,
.dport = th->source } } };
security_req_classify_flow(req, &fl);
- if (ip_route_output_key(&init_net, &rt, &fl)) {
+ if (ip_route_output_key(sock_net(sk), &rt, &fl)) {
reqsk_free(req);
goto out;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tcp: use correct net ns in cookie_v4_check()
2010-06-03 15:45 [PATCH] tcp: use correct net ns in cookie_v4_check() Eric Dumazet
@ 2010-06-04 22:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-06-04 22:57 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 03 Jun 2010 17:45:47 +0200
> [PATCH] tcp: use correct net ns in cookie_v4_check()
>
> Its better to make a route lookup in appropriate namespace.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied and queued up for -stable, thanks Eric!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-04 22:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03 15:45 [PATCH] tcp: use correct net ns in cookie_v4_check() Eric Dumazet
2010-06-04 22:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox