Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>, Patrick McHardy <kaber@trash.net>
Subject: [PATCH] vlan: allow TSO setting on vlan interfaces
Date: Wed, 07 Jul 2010 19:14:34 +0200	[thread overview]
Message-ID: <1278522874.5906.9.camel@edumazet-laptop> (raw)

When we need to shape traffic with low speeds, we need to disable tso on
network interface :

ethtool -K eth0.2240 tso off

It seems vlan interfaces miss the set_tso() ethtool method.
Propagating tso changes from lower device is not always wanted, some
vlan want TSO on, other want TSO off.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---

diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index c6456cb..d827c2e 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -844,6 +844,7 @@ static const struct ethtool_ops vlan_ethtool_ops = {
 	.get_link		= ethtool_op_get_link,
 	.get_rx_csum		= vlan_ethtool_get_rx_csum,
 	.get_flags		= vlan_ethtool_get_flags,
+	.set_tso		= ethtool_op_set_tso,
 };
 
 static const struct net_device_ops vlan_netdev_ops = {



             reply	other threads:[~2010-07-07 17:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07 17:14 Eric Dumazet [this message]
2010-07-07 17:25 ` [PATCH] vlan: allow TSO setting on vlan interfaces Ben Hutchings
2010-07-08  6:46   ` Eric Dumazet
2010-07-08  9:39     ` [PATCH v2] " Eric Dumazet
2010-07-08 15:43       ` Ben Hutchings
2010-07-08 15:49         ` Ben Hutchings
2010-07-08 15:55           ` Patrick McHardy
2010-07-08 16:04             ` Eric Dumazet
2010-07-08 16:00           ` Eric Dumazet
2010-07-08 16:05             ` Ben Hutchings
2010-07-08 16:12               ` Eric Dumazet
2010-07-08 16:03         ` Eric Dumazet
2010-07-08 16:37           ` [PATCH v3] " Eric Dumazet
2010-07-08 18:25             ` Ben Hutchings
2010-07-09  6:10               ` David Miller
2010-07-09  6:10       ` [PATCH v2] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278522874.5906.9.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox