From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] vlan: allow TSO setting on vlan interfaces
Date: Thu, 08 Jul 2010 08:46:27 +0200 [thread overview]
Message-ID: <1278571587.2543.9.camel@edumazet-laptop> (raw)
In-Reply-To: <1278523511.2080.3.camel@achroite.uk.solarflarecom.com>
Le mercredi 07 juillet 2010 à 18:25 +0100, Ben Hutchings a écrit :
> On Wed, 2010-07-07 at 19:14 +0200, Eric Dumazet wrote:
> > When we need to shape traffic with low speeds, we need to disable tso on
> > network interface :
> >
> > ethtool -K eth0.2240 tso off
> >
> > It seems vlan interfaces miss the set_tso() ethtool method.
> > Propagating tso changes from lower device is not always wanted, some
> > vlan want TSO on, other want TSO off.
>
> But it should not be possible to enable TSO if the underlying device
> doesn't support it.
Yes indeed, I'll provide a more generic patch, thanks !
next prev parent reply other threads:[~2010-07-08 6:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 17:14 [PATCH] vlan: allow TSO setting on vlan interfaces Eric Dumazet
2010-07-07 17:25 ` Ben Hutchings
2010-07-08 6:46 ` Eric Dumazet [this message]
2010-07-08 9:39 ` [PATCH v2] " Eric Dumazet
2010-07-08 15:43 ` Ben Hutchings
2010-07-08 15:49 ` Ben Hutchings
2010-07-08 15:55 ` Patrick McHardy
2010-07-08 16:04 ` Eric Dumazet
2010-07-08 16:00 ` Eric Dumazet
2010-07-08 16:05 ` Ben Hutchings
2010-07-08 16:12 ` Eric Dumazet
2010-07-08 16:03 ` Eric Dumazet
2010-07-08 16:37 ` [PATCH v3] " Eric Dumazet
2010-07-08 18:25 ` Ben Hutchings
2010-07-09 6:10 ` David Miller
2010-07-09 6:10 ` [PATCH v2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278571587.2543.9.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox