Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: Felipe W Damasio <felipewd@gmail.com>,
	David Miller <davem@davemloft.net>,
	Patrick McHardy <kaber@trash.net>,
	linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] tproxy: nf_tproxy_assign_sock() can handle tw sockets
Date: Sun, 11 Jul 2010 10:02:12 +0200	[thread overview]
Message-ID: <1278835332.2538.51.camel@edumazet-laptop> (raw)
In-Reply-To: <4C395459.6080407@redhat.com>

Le dimanche 11 juillet 2010 à 08:19 +0300, Avi Kivity a écrit :
> On 07/10/2010 09:17 AM, Eric Dumazet wrote:
> >
> > Strange thing with your crash report is CR2 value, with unexpected value
> > of 000000000b388000 while RAX value is dce8dce85d415d41
> >
> > Faulting instruction is :
> >
> > 48 83 b8 b0 00 00 00 00   cmpq   $0x0,0xb0(%rax)
> >
> > So I would have expected CR2 being RAX+0xb0, but its not.
> >    
> 
> Nothing strange about it.  You only get page faults and valid cr2 for 
> canonical addresses (17 high order bits all equal).  In this case 
> rax+0xb0 is not a canonical address, so you got a general protection 
> fault instead, with cr2 unchanged.
> 

OK, thanks Avi for this information, as I was not aware of this.

So something overwrote sk->sk_prot pointer (or skb->sk pointer) with
some data.

tcp sockets are allocated from a dedicated kmem_cache (because of
SLAB_DESTROY_RCU attribute). Their sk->sk_prot should never change in
normal operation, since underlying memory cannot be reused by another
object type in kernel. It should be NULL or &tcp_prot

Felipe, please describe your configuration as much as possible.
It might be a driver bug with with special kind of network frames.

lsmod
lspci -v
ethtool -k eth0
ethtool -k eth1 (if applicable)

  reply	other threads:[~2010-07-11  8:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTimn8A0cYZmwNZYitRkBHKKFe4HQ5GU626DLugkk@mail.gmail.com>
2010-07-08 22:06 ` Squid hang up on 2.6.34 Eric Dumazet
     [not found] ` <AANLkTil49m6Ul2bauiH4Pwn-6ykrYTFmSO6_SxqQgD_e@mail.gmail.com>
2010-07-08 22:08   ` Eric Dumazet
2010-07-09 15:03     ` Felipe W Damasio
2010-07-09 16:03       ` Felipe W Damasio
2010-07-09 17:13       ` [PATCH] tproxy: nf_tproxy_assign_sock() can handle tw sockets Eric Dumazet
2010-07-09 17:53         ` David Miller
2010-07-09 18:16         ` Felipe W Damasio
2010-07-10  3:18         ` Felipe W Damasio
2010-07-10  6:17           ` Eric Dumazet
2010-07-10 19:30             ` David Miller
2010-07-11  3:11               ` Felipe W Damasio
2010-07-11  7:11                 ` Felipe W Damasio
2010-07-11  7:13                   ` Felipe W Damasio
2010-07-11  8:36               ` Eric Dumazet
2010-07-11  5:19             ` Avi Kivity
2010-07-11  8:02               ` Eric Dumazet [this message]
2010-07-12  0:52                 ` Felipe W Damasio
2010-07-12 18:49                   ` Felipe W Damasio
2010-07-13 14:24                     ` Felipe W Damasio
2010-07-13 14:40                       ` Eric Dumazet
2010-07-13 14:49                         ` Felipe W Damasio
2010-07-13 15:49                           ` Eric Dumazet
2010-07-13 20:55                             ` Felipe W Damasio
2010-07-13 21:06                               ` Felipe W Damasio
2010-07-14  3:21                               ` Eric Dumazet
2010-07-14  3:27                                 ` Felipe W Damasio
2010-07-14  3:43                                   ` Eric Dumazet
2010-07-14  3:51                                     ` Felipe W Damasio
2010-07-14  6:56                                       ` Bill Fink
2010-07-16 15:41                                   ` Felipe W Damasio
2010-07-16 15:52                                     ` Eric Dumazet
2010-07-14 11:41         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278835332.2538.51.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=avi@redhat.com \
    --cc=davem@davemloft.net \
    --cc=felipewd@gmail.com \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox