Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dmitry Kozlov <xeb@mail.ru>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v7] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)
Date: Fri, 20 Aug 2010 08:24:59 +0200	[thread overview]
Message-ID: <1282285499.2295.2.camel@edumazet-laptop> (raw)
In-Reply-To: <E1Om1Q6-0005Fm-00.xeb-mail-ru@f239.mail.ru>

Le jeudi 19 août 2010 à 13:28 +0400, Dmitry Kozlov a écrit :
> Ang again...
> This patch contains:
> 1. pptp driver
> 2. gre demultiplexer driver for demultiplexing gre packets with different gre version
> so ip_gre and pptp may coexists
> 3. ip_gre modification
> 4. other stuff
> 
> Changes from v6:
> 1. memory allocation moved to begin of module initialization
> 2. fixed coding style issues
> Thanks to Eric Dumazet.
> 
> --
>  MAINTAINERS              |   14 +
>  drivers/net/Kconfig      |   11 +
>  drivers/net/Makefile     |    1 +
>  drivers/net/pptp.c       |  726 ++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/if_pppox.h |   59 +++--
>  include/net/gre.h        |   18 ++
>  net/ipv4/Kconfig         |    7 +
>  net/ipv4/Makefile        |    1 +
>  net/ipv4/gre.c           |  151 ++++++++++
>  net/ipv4/ip_gre.c        |   14 +-
>  10 files changed, 975 insertions(+), 27 deletions(-)


Seems fine to me, but you need to make a nice looking Changelog and add
your "Signed-off-by: ...." signature.

Thanks



  reply	other threads:[~2010-08-20  6:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19  9:28 [PATCH v7] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol) Dmitry Kozlov
2010-08-20  6:24 ` Eric Dumazet [this message]
2010-08-20 15:28   ` Re[2]: " Dmitry Kozlov
2010-08-20 15:50     ` Eric Dumazet
2010-08-20 15:59       ` Eric Dumazet
  -- strict thread matches above, loose matches on Subject: below --
2010-08-19  9:26 Dmitry Kozlov
2010-08-19  9:22 Dmitry Kozlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282285499.2295.2.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xeb@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox