Re: Re[2]: [PATCH v7] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)

[Eric Dumazet <eric.dumazet@gmail.com>]

Le vendredi 20 août 2010 à 19:28 +0400, Dmitry Kozlov a écrit :
> > > Ang again...
> > > This patch contains:
> > > 1. pptp driver
> > > 2. gre demultiplexer driver for demultiplexing gre packets with different gre version
> > > so ip_gre and pptp may coexists
> > > 3. ip_gre modification
> > > 4. other stuff
> > > 
> > > Changes from v6:
> > > 1. memory allocation moved to begin of module initialization
> > > 2. fixed coding style issues
> > > Thanks to Eric Dumazet.
> > > 
> > > --
> > >  MAINTAINERS              |   14 +
> > >  drivers/net/Kconfig      |   11 +
> > >  drivers/net/Makefile     |    1 +
> > >  drivers/net/pptp.c       |  726 ++++++++++++++++++++++++++++++++++++++++++++++
> > >  include/linux/if_pppox.h |   59 +++--
> > >  include/net/gre.h        |   18 ++
> > >  net/ipv4/Kconfig         |    7 +
> > >  net/ipv4/Makefile        |    1 +
> > >  net/ipv4/gre.c           |  151 ++++++++++
> > >  net/ipv4/ip_gre.c        |   14 +-
> > >  10 files changed, 975 insertions(+), 27 deletions(-)
> > 
> > 
> > Seems fine to me, but you need to make a nice looking Changelog and add
> > your "Signed-off-by: ...." signature.
> > 
> > Thanks
> 
> What do you mean, Changelog of patch ?

I mean the head of your patch that read :
-----------------------------------------------------------------
Ang again...
This patch contains:
1. pptp driver
2. gre demultiplexer driver for demultiplexing gre packets with
different gre version
so ip_gre and pptp may coexists
3. ip_gre modification
4. other stuff

Changes from v6:
1. memory allocation moved to begin of module initialization
2. fixed coding style issues
Thanks to Eric Dumazet.
-------------------------------------------------------------------

This is not a very good Changelog for the final code inclusion in
Linux :). You spent a lot of time in preparing these patches, you can
polish the text so that casual reader have an idea of what you did...

'Ang again...' ?

Dont include "changes from v6" or include all changes (v2,v3, ...)

Of course, once I reviewed your final version, I'll add my signature,
and other netdev developpers (including David S. Miller) might find
other problems that I missed, so what I called 'final code' might be a
not so final...

Thanks