From: Joe Perches <joe@perches.com>
To: Elly Jones <ellyjones@google.com>
Cc: netdev@vger.kernel.org, dbrownell@users.sourceforge.net,
mjg59@srcf.ucam.org, jglasgow@google.com, msb@google.com,
olofj@google.com
Subject: Re: [PATCH] Add Qualcomm Gobi 2000 driver.
Date: Tue, 28 Sep 2010 11:11:40 -0700 [thread overview]
Message-ID: <1285697500.1866.100.camel@Joe-Laptop> (raw)
In-Reply-To: <20100928171026.GB6083@google.com>
On Tue, 2010-09-28 at 13:10 -0400, Elly Jones wrote:
> From: Elizabeth Jones <ellyjones@google.com>
Hi.
The readme is out of date and should be updated.
[]
> +#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,23)
> + usbnet = usb_get_intfdata(iface);
> +#else
> + usbnet = iface->dev.platform_data;
> +#endif
I think it's not particularly useful to include support
for versions < current when this driver is added.
[]
> +#define DBG(format, arg...) \
> + if (debug == 1) { \
> + printk(KERN_INFO "QCUSBNet2k::%s " format, __FUNCTION__, ## arg); \
> + }
This should be surrounded by a do {} while(0)
#define DBG(fmt, arg...) \
do { \
if (debug == 1) \
printk(KERN_INFO "QCUSBNet2k::%s " fmt, __func__, ##arg); \
} while (0)
I think many of these DBG messages should
not use DBG but the more normal pr_<level>,
dev_<level> or netdev_<level> so generally
useful messages are logged without getting
all the debugging messages.
next prev parent reply other threads:[~2010-09-28 18:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 17:10 [PATCH] Add Qualcomm Gobi 2000 driver Elly Jones
2010-09-28 17:16 ` Ben Hutchings
2010-09-28 18:11 ` Joe Perches [this message]
2010-09-28 21:23 ` Dan Williams
2010-10-04 15:03 ` Elly Jones
2010-09-29 2:39 ` [PATCH 0/2] qcusbnet: Cleanups Joe Perches
2010-09-29 2:39 ` [PATCH 1/2] drivers/net/usb/qcusbnet: Checkpatch cleanups Joe Perches
2010-09-29 3:09 ` [PATCH 3] drivers/net/usb/qcusbnet: Spelling and extern int debug cleanups Joe Perches
2010-10-01 13:26 ` [PATCH 1/2] drivers/net/usb/qcusbnet: Checkpatch cleanups Paulius Zaleckas
2010-10-01 13:41 ` Joe Perches
2010-10-01 13:54 ` Paulius Zaleckas
2010-09-29 2:39 ` [PATCH 2/2] drivers/net/usb/qcusbnet/qmidevice: Remove printhex, use print_hex_dump Joe Perches
2010-10-01 0:33 ` [PATCH 0/2] qcusbnet: Cleanups David Miller
2010-10-01 0:45 ` Joe Perches
2010-10-01 14:42 ` Elly Jones
2010-10-01 15:56 ` Joe Perches
2010-10-01 18:29 ` David Brownell
2010-10-01 13:37 ` [PATCH] Add Qualcomm Gobi 2000 driver Paulius Zaleckas
2010-10-01 13:50 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285697500.1866.100.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=dbrownell@users.sourceforge.net \
--cc=ellyjones@google.com \
--cc=jglasgow@google.com \
--cc=mjg59@srcf.ucam.org \
--cc=msb@google.com \
--cc=netdev@vger.kernel.org \
--cc=olofj@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox