From: Joe Perches <joe@perches.com>
To: Elly Jones <ellyjones@google.com>
Cc: netdev@vger.kernel.org, dbrownell@users.sourceforge.net,
mjg59@srcf.ucam.org, jglasgow@google.com, msb@google.com,
olofj@google.com
Subject: [PATCH 3] drivers/net/usb/qcusbnet: Spelling and extern int debug cleanups
Date: Tue, 28 Sep 2010 20:09:24 -0700 [thread overview]
Message-ID: <1285729764.1866.161.camel@Joe-Laptop> (raw)
In-Reply-To: <0aa502d0e385f2333f8bc12dafdcde88e5ca0262.1285727642.git.joe@perches.com>
Some miscellaneous typo cleanups.
Add missing newlines to DBG messages.
"debug" is not a good global variable name, use qcusbnet_debug instead.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/usb/qcusbnet/qcusbnet.c | 10 +++++-----
drivers/net/usb/qcusbnet/qmidevice.c | 6 +++---
drivers/net/usb/qcusbnet/structs.h | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/usb/qcusbnet/qcusbnet.c b/drivers/net/usb/qcusbnet/qcusbnet.c
index 54a354e..7e218a8 100644
--- a/drivers/net/usb/qcusbnet/qcusbnet.c
+++ b/drivers/net/usb/qcusbnet/qcusbnet.c
@@ -25,7 +25,7 @@
#define DRIVER_AUTHOR "Qualcomm Innovation Center"
#define DRIVER_DESC "QCUSBNet2k"
-int debug;
+int qcusbnet_debug;
static struct class *devclass;
int qc_suspend(struct usb_interface *iface, pm_message_t event)
@@ -558,7 +558,7 @@ int qcnet_probe(struct usb_interface *iface, const struct usb_device_id *vidpids
dev = kmalloc(sizeof(struct qcusbnet), GFP_KERNEL);
if (!dev) {
- DBG("falied to allocate device buffers");
+ DBG("failed to allocate device buffers\n");
return -ENOMEM;
}
@@ -568,7 +568,7 @@ int qcnet_probe(struct usb_interface *iface, const struct usb_device_id *vidpids
netdevops = kmalloc(sizeof(struct net_device_ops), GFP_KERNEL);
if (!netdevops) {
- DBG("falied to allocate net device ops");
+ DBG("failed to allocate net device ops\n");
return -ENOMEM;
}
memcpy(netdevops, usbnet->net->netdev_ops, sizeof(struct net_device_ops));
@@ -645,5 +645,5 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("Dual BSD/GPL");
-module_param(debug, bool, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(debug, "Debuging enabled or not");
+module_param(qcusbnet_debug, bool, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(qcusbnet_debug, "Debugging enabled or not");
diff --git a/drivers/net/usb/qcusbnet/qmidevice.c b/drivers/net/usb/qcusbnet/qmidevice.c
index 5150453..d1cb341 100755
--- a/drivers/net/usb/qcusbnet/qmidevice.c
+++ b/drivers/net/usb/qcusbnet/qmidevice.c
@@ -54,7 +54,7 @@ struct qmihandle {
struct qcusbnet *dev;
};
-extern int debug;
+extern int qcusbnet_debug;
static int qcusbnet2k_fwdelay;
static bool device_valid(struct qcusbnet *dev);
@@ -339,12 +339,12 @@ int qc_startread(struct qcusbnet *dev)
void qc_stopread(struct qcusbnet *dev)
{
if (dev->qmi.readurb) {
- DBG("Killng read URB\n");
+ DBG("Killing read URB\n");
usb_kill_urb(dev->qmi.readurb);
}
if (dev->qmi.inturb) {
- DBG("Killng int URB\n");
+ DBG("Killing int URB\n");
usb_kill_urb(dev->qmi.inturb);
}
diff --git a/drivers/net/usb/qcusbnet/structs.h b/drivers/net/usb/qcusbnet/structs.h
index 2999e62..7a89c5c 100755
--- a/drivers/net/usb/qcusbnet/structs.h
+++ b/drivers/net/usb/qcusbnet/structs.h
@@ -33,7 +33,7 @@
#define DBG(fmt, arg...) \
do { \
- if (debug == 1) \
+ if (qcusbnet_debug == 1) \
printk(KERN_INFO "QCUSBNet2k::%s " fmt, __func__, ##arg); \
} while (0)
next prev parent reply other threads:[~2010-09-29 3:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 17:10 [PATCH] Add Qualcomm Gobi 2000 driver Elly Jones
2010-09-28 17:16 ` Ben Hutchings
2010-09-28 18:11 ` Joe Perches
2010-09-28 21:23 ` Dan Williams
2010-10-04 15:03 ` Elly Jones
2010-09-29 2:39 ` [PATCH 0/2] qcusbnet: Cleanups Joe Perches
2010-09-29 2:39 ` [PATCH 1/2] drivers/net/usb/qcusbnet: Checkpatch cleanups Joe Perches
2010-09-29 3:09 ` Joe Perches [this message]
2010-10-01 13:26 ` Paulius Zaleckas
2010-10-01 13:41 ` Joe Perches
2010-10-01 13:54 ` Paulius Zaleckas
2010-09-29 2:39 ` [PATCH 2/2] drivers/net/usb/qcusbnet/qmidevice: Remove printhex, use print_hex_dump Joe Perches
2010-10-01 0:33 ` [PATCH 0/2] qcusbnet: Cleanups David Miller
2010-10-01 0:45 ` Joe Perches
2010-10-01 14:42 ` Elly Jones
2010-10-01 15:56 ` Joe Perches
2010-10-01 18:29 ` David Brownell
2010-10-01 13:37 ` [PATCH] Add Qualcomm Gobi 2000 driver Paulius Zaleckas
2010-10-01 13:50 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285729764.1866.161.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=dbrownell@users.sourceforge.net \
--cc=ellyjones@google.com \
--cc=jglasgow@google.com \
--cc=mjg59@srcf.ucam.org \
--cc=msb@google.com \
--cc=netdev@vger.kernel.org \
--cc=olofj@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox