From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Michael Chan <mchan@broadcom.com>,
Eilon Greenstein <eilong@broadcom.com>
Subject: Re: [PATCH net-next] bnx2x: dont use netdev_alloc_skb()
Date: Tue, 12 Oct 2010 07:16:00 +0200 [thread overview]
Message-ID: <1286860560.30423.186.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTi=NvnPov_=KQJz2uXt1R-ep4oahDF0J=3HwhGzG@mail.gmail.com>
Le lundi 11 octobre 2010 à 22:03 -0700, Tom Herbert a écrit :
> On Mon, Oct 11, 2010 at 4:22 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > Le mardi 12 octobre 2010 à 01:03 +0200, Eric Dumazet a écrit :
> >> netdev_alloc_skb() is a very wrong interface, really.
> >>
> >> We should remove/deprecate it.
> >>
> >> For multi queue devices, it makes more sense to allocate skb on local
> >> node of the cpu handling RX interrupts. This allow each cpu to
> >> manipulate its own slub/slab queues/structures without doing expensive
> >> cross-node business.
> >>
> >> For non multi queue devices, IRQ affinity should be set so that a cpu
> >> close to the device services interrupts. Even if not set, using
> >> dev_alloc_skb() is faster.
> >>
> >> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> >
> > Or maybe revert :
> >
> > commit b30973f877fea1a3fb84e05599890fcc082a88e5
> > Author: Christoph Hellwig <hch@lst.de>
> > Date: Wed Dec 6 20:32:36 2006 -0800
> >
>
> I second this revert. Node aware allocation by device's node makes
> little sense on a multi-queue device and leads to mediocre
> performance.
Yes, I said this several time in the past, I believe time has come to
get rid of it.
I posted a patch some minutes ago, so you can review it and ack it ;)
Thanks !
next prev parent reply other threads:[~2010-10-12 5:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 23:03 [PATCH net-next] bnx2x: dont use netdev_alloc_skb() Eric Dumazet
2010-10-11 23:22 ` Eric Dumazet
2010-10-12 5:03 ` Tom Herbert
2010-10-12 5:16 ` Eric Dumazet [this message]
2010-10-12 9:12 ` Vladislav Zolotarov
2010-10-14 17:39 ` David Miller
2010-10-14 18:17 ` Eilon Greenstein
2010-10-14 18:20 ` Eric Dumazet
2010-10-14 18:25 ` David Miller
2010-10-14 18:17 ` Tom Herbert
2010-10-12 5:05 ` [PATCH net-next] net: allocate skbs on local node Eric Dumazet
2010-10-12 5:35 ` Tom Herbert
2010-10-12 6:03 ` Andrew Morton
2010-10-12 6:58 ` Eric Dumazet
2010-10-12 7:24 ` Andrew Morton
2010-10-12 7:49 ` Eric Dumazet
2010-10-12 7:58 ` Andrew Morton
2010-10-12 11:08 ` Pekka Enberg
2010-10-12 12:50 ` Christoph Lameter
2010-10-12 19:43 ` David Rientjes
2010-10-13 6:17 ` Pekka Enberg
2010-10-13 6:31 ` David Rientjes
2010-10-13 6:36 ` Pekka Enberg
2010-10-13 16:00 ` Christoph Lameter
2010-10-13 20:48 ` David Rientjes
2010-10-13 21:43 ` Christoph Lameter
2010-10-13 22:41 ` David Rientjes
2010-10-14 6:22 ` Pekka Enberg
2010-10-14 7:23 ` David Rientjes
2010-10-15 14:23 ` Christoph Lameter
2010-10-14 15:31 ` Tom Herbert
2010-10-14 16:05 ` Eric Dumazet
2010-10-15 16:57 ` Christoph Lameter
2010-10-14 19:27 ` Andrew Morton
2010-10-14 19:59 ` Eric Dumazet
2010-10-16 18:54 ` David Miller
2010-10-12 16:07 ` [BUG net-next] bnx2x: all traffic comes to RX queue 0 Eric Dumazet
2010-10-12 16:20 ` Dmitry Kravkov
2010-10-12 18:11 ` Eric Dumazet
2010-10-12 18:18 ` Vladislav Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286860560.30423.186.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox