Netdev List
 help / color / mirror / Atom feed
* [PATCH v2] davinci_emac: Add Carrier Link OK check in Davinci RX Handler
@ 2011-02-28  8:15 Hegde, Vinay
  0 siblings, 0 replies; only message in thread
From: Hegde, Vinay @ 2011-02-28  8:15 UTC (permalink / raw)
  To: netdev; +Cc: khilman, davinci-linux-open-source, linux-arm-kernel,
	Hegde, Vinay

This patch adds an additional check in the Davinci EMAC RX Handler,
which tests the __LINK_STATE_NOCARRIER flag along with the
__LINK_STATE_START flag as part EMAC shutting down procedure.

This avoids
WARNING: at drivers/net/davinci_emac.c:1040 emac_rx_handler+0xf8/0x120()
during rtcwake used to suspend the target for a specified duration.

Signed-off-by: Hegde, Vinay <vinay.hegde@ti.com>
Acked-by: Cyril Chemparathy <cyril@ti.com>
---
since v1: Changed the subject line

 drivers/net/davinci_emac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 2a628d1..7018bfe 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -1008,7 +1008,7 @@ static void emac_rx_handler(void *token, int len, int status)
 	int			ret;
 
 	/* free and bail if we are shutting down */
-	if (unlikely(!netif_running(ndev))) {
+	if (unlikely(!netif_running(ndev) || !netif_carrier_ok(ndev))) {
 		dev_kfree_skb_any(skb);
 		return;
 	}
-- 
1.7.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-02-28  8:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-28  8:15 [PATCH v2] davinci_emac: Add Carrier Link OK check in Davinci RX Handler Hegde, Vinay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox