From: Eric Dumazet <eric.dumazet@gmail.com>
To: Po-Yu Chuang <ratbert.chuang@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Po-Yu Chuang <ratbert@faraday-tech.com>
Subject: Re: [PATCH] net: add Faraday FTGMAC100 Gigabit Ethernet driver
Date: Sun, 13 Mar 2011 21:16:28 +0100 [thread overview]
Message-ID: <1300047388.2761.48.camel@edumazet-laptop> (raw)
In-Reply-To: <1299744517-1896-1-git-send-email-ratbert.chuang@gmail.com>
Le jeudi 10 mars 2011 à 16:08 +0800, Po-Yu Chuang a écrit :
> From: Po-Yu Chuang <ratbert@faraday-tech.com>
>
> FTGMAC100 Ethernet Media Access Controller supports 10/100/1000 Mbps
> and MII/GMII. This driver has been working on some ARM/NDS32 SoC's
> including Faraday A369 and Andes AG102.
>
Hi
It seems very close from drivers/net/ftmac100.c one. Are you sure a
factorization is not possible ?
BTW, it seems I missed the fact that ftmac100_alloc_rx_page() used a
GFP_KERNEL allocation, while its called from softirq context (from
ftmac100_rx_packet())
Same problem of course in this Gigabit driver.
next prev parent reply other threads:[~2011-03-13 20:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 8:08 [PATCH] net: add Faraday FTGMAC100 Gigabit Ethernet driver Po-Yu Chuang
2011-03-13 20:16 ` Eric Dumazet [this message]
2011-03-13 20:26 ` [PATCH net-next-2.6] ftmac100: use GFP_ATOMIC allocations where needed Eric Dumazet
2011-03-13 20:29 ` Eric Dumazet
2011-03-14 8:16 ` Po-Yu Chuang
2011-03-14 14:26 ` [PATCH net-next-2.6 v2] " Eric Dumazet
2011-03-14 22:40 ` David Miller
2011-03-14 8:38 ` [PATCH] net: add Faraday FTGMAC100 Gigabit Ethernet driver Po-Yu Chuang
2011-03-17 9:47 ` [PATCH v2] " Po-Yu Chuang
2011-03-17 10:24 ` Eric Dumazet
2011-03-17 10:56 ` Po-Yu Chuang
2011-03-17 11:30 ` Eric Dumazet
2011-03-21 7:54 ` Po-Yu Chuang
2011-03-21 8:19 ` Eric Dumazet
2011-06-09 9:32 ` [PATCH v3] " Po-Yu Chuang
2011-06-11 22:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300047388.2761.48.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ratbert.chuang@gmail.com \
--cc=ratbert@faraday-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox