From: Eric Dumazet <eric.dumazet@gmail.com>
To: Po-Yu Chuang <ratbert.chuang@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Po-Yu Chuang <ratbert@faraday-tech.com>
Subject: Re: [PATCH net-next-2.6] ftmac100: use GFP_ATOMIC allocations where needed
Date: Sun, 13 Mar 2011 21:29:53 +0100 [thread overview]
Message-ID: <1300048193.2761.55.camel@edumazet-laptop> (raw)
In-Reply-To: <1300048002.2761.53.camel@edumazet-laptop>
Le dimanche 13 mars 2011 à 21:26 +0100, Eric Dumazet a écrit :
> Le dimanche 13 mars 2011 à 21:16 +0100, Eric Dumazet a écrit :
>
> > BTW, it seems I missed the fact that ftmac100_alloc_rx_page() used a
> > GFP_KERNEL allocation, while its called from softirq context (from
> > ftmac100_rx_packet())
>
> Here is a patch against ftmac100
>
Oops, one typo in it sorry
> -static int ftmac100_alloc_rx_page(struct ftmac100 *priv, struct ftmac100_rxdes *rxdes)
> +static int ftmac100_alloc_rx_page(struct ftmac100 *priv,
> + struct ftmac100_rxdes *rxdes, gtp_t gfp)
Should be : gfp_t gfp
Please build and test the patch, I dont have an ARM testbed anyway.
Thanks
next prev parent reply other threads:[~2011-03-13 20:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 8:08 [PATCH] net: add Faraday FTGMAC100 Gigabit Ethernet driver Po-Yu Chuang
2011-03-13 20:16 ` Eric Dumazet
2011-03-13 20:26 ` [PATCH net-next-2.6] ftmac100: use GFP_ATOMIC allocations where needed Eric Dumazet
2011-03-13 20:29 ` Eric Dumazet [this message]
2011-03-14 8:16 ` Po-Yu Chuang
2011-03-14 14:26 ` [PATCH net-next-2.6 v2] " Eric Dumazet
2011-03-14 22:40 ` David Miller
2011-03-14 8:38 ` [PATCH] net: add Faraday FTGMAC100 Gigabit Ethernet driver Po-Yu Chuang
2011-03-17 9:47 ` [PATCH v2] " Po-Yu Chuang
2011-03-17 10:24 ` Eric Dumazet
2011-03-17 10:56 ` Po-Yu Chuang
2011-03-17 11:30 ` Eric Dumazet
2011-03-21 7:54 ` Po-Yu Chuang
2011-03-21 8:19 ` Eric Dumazet
2011-06-09 9:32 ` [PATCH v3] " Po-Yu Chuang
2011-06-11 22:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300048193.2761.55.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ratbert.chuang@gmail.com \
--cc=ratbert@faraday-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox