Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesper Dangaard Brouer <hawk@diku.dk>
Cc: David Miller <davem@davemloft.net>,
	Patrick McHardy <kaber@trash.net>,
	Netfilter Developers <netfilter-devel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] netfilter: xtables: fix reentrancy
Date: Thu, 17 Mar 2011 12:45:23 +0100	[thread overview]
Message-ID: <1300362323.3133.195.camel@edumazet-laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.1103171231220.21558@ask.diku.dk>

Le jeudi 17 mars 2011 à 12:36 +0100, Jesper Dangaard Brouer a écrit :
> Hi Eric,
> 
> How critial is this bug fix?
> 
> Should I apply this on my stable production kernels?
> (I'm preparing a 2.6.38 kernel for prod usage, eventhougt its just been 
> released, because I want your SFQ fixes...)

I would say the race is there, but probability must be very small, and
might need malicious iptables rules (with RETURN targets)

Especially in routers, where OUTPUT path is taken from softirq handler
anyway ;)

So dont worry at all, consider this as a cleanup :)


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-03-17 11:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 19:00 [RFC] netfilter: get rid of atomic ops in fast path Eric Dumazet
2011-03-16 20:16 ` David Miller
2011-03-17 10:35   ` [PATCH] netfilter: xtables: fix reentrancy Eric Dumazet
2011-03-17 11:36     ` Jesper Dangaard Brouer
2011-03-17 11:45       ` Eric Dumazet [this message]
2011-03-17 13:17         ` Eric Dumazet
2011-03-18 10:27           ` Jesper Dangaard Brouer
2011-03-18 10:50             ` Eric Dumazet
2011-03-17 10:39 ` [RFC] netfilter: get rid of atomic ops in fast path Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300362323.3133.195.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hawk@diku.dk \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox