From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesper Dangaard Brouer <hawk@diku.dk>
Cc: David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
Netfilter Developers <netfilter-devel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] netfilter: xtables: fix reentrancy
Date: Fri, 18 Mar 2011 11:50:27 +0100 [thread overview]
Message-ID: <1300445427.2888.23.camel@edumazet-laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.1103181113040.21558@ask.diku.dk>
Le vendredi 18 mars 2011 à 11:27 +0100, Jesper Dangaard Brouer a écrit :
> I have actually enabled PREEMPTion, am I in trouble then?
>
Well, to get problem on localy generated trafic (as all forwarding is
done from softirq handler), you'll need a malicious -j RETURN in OUTPUT
hook (in the OUTPUT chain, not a called one)
Also, even for localy generated trafic, I guess most callers block BH
before calling ipt_do_table() anyway...
> I have modified the .config I got from you, quite a lot, during my
> attempts to find the CCISS/HPSA problem.
>
> Which reminds me that I needed to enable, the follwing config options,
> (which your config didn't have):
> CONFIG_PCIEASPM=y
> CONFIG_X86_X2APIC=y
>
> In order to get rid of a PCI warning:
> NMI: PCI system error (SERR) for reason b1 on CPU 0.
> Dazed and confused, but trying to continue
>
> The system worked fine, and you might not see this issue on your G6
> servers, as its most likely BIOS related (my server is a HP DL370 G6).
>
Mine is ProLiant BL460c G6
> FYI: Operations have deployed the kernel on prod server this morning.
Okay, lets pray ;)
next prev parent reply other threads:[~2011-03-18 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 19:00 [RFC] netfilter: get rid of atomic ops in fast path Eric Dumazet
2011-03-16 20:16 ` David Miller
2011-03-17 10:35 ` [PATCH] netfilter: xtables: fix reentrancy Eric Dumazet
2011-03-17 11:36 ` Jesper Dangaard Brouer
2011-03-17 11:45 ` Eric Dumazet
2011-03-17 13:17 ` Eric Dumazet
2011-03-18 10:27 ` Jesper Dangaard Brouer
2011-03-18 10:50 ` Eric Dumazet [this message]
2011-03-17 10:39 ` [RFC] netfilter: get rid of atomic ops in fast path Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300445427.2888.23.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=hawk@diku.dk \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox