Re: LRO disable warnings on kernel 2.6.38

[Ben Hutchings <bhutchings@solarflare.com>]

On Fri, 2011-03-18 at 12:52 -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 18 Mar 2011 08:15:24 -0700
> 
> > On Fri, 18 Mar 2011 15:33:04 +0100
> > Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > 
> >> Le vendredi 18 mars 2011 à 14:17 +0000, Ben Hutchings a écrit :
> >> 
> >> > WARN is correct as this is a driver bug.  But I agree that the
> >> > device/driver ID should be included.
> >> 
> >> stack trace gives absolutely no useful indication here.
> >> 
> >> Bug is in driver, yet we dump information on core network stack ?
> >> 
> >> pr_err() is an error indication, not a warning by the way ;)
> > 
> > The advantage of WARN is that it doesn't get ignored and shows
> > up in kernel oops. But agreed it should print out as much device
> > info as possible to finger the broken device driver.
> 
> Infrastructure is not static, therefore we could add a WARN_ON_NETDEV()
> or similar.  An in fact such things would probably be very useful.

You mean like netdev_WARN()? :-)

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.