From: "Vladislav Zolotarov" <vladz@broadcom.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Eilon Greenstein" <eilong@broadcom.com>
Subject: Re: [PATCH v2] net: bnx2x: convert to hw_features
Date: Tue, 12 Apr 2011 10:46:19 +0300 [thread overview]
Message-ID: <1302594379.32697.33.camel@lb-tlvb-vladz> (raw)
In-Reply-To: <1302593208.32697.18.camel@lb-tlvb-vladz>
> > In all those cases, bnx2x_reload_if_running() will be called only when
> > LRO state is changed while there's a recovery in progress.
>
> Hmmm... And what about all other features from hw_features? What if they
> have changed (in wanted_features) while recovery was in progress?
> According to the __netdev_update_features() code it will invoke
> ndo_set_features() in these cases either. Do I miss something here?
I think I understood what u meant. So, yes, if the bnx2x_nic_load()
called only if TPA_ENABLED_FLAG in bp->flags has changed. And this can
happen if either NETIF_F_LRO has changed while NETIF_F_RXCSUM was set or
if NETIF_F_LRO was set and NETIF_F_RXCSUM is being cleared.
thanks,
vlad
prev parent reply other threads:[~2011-04-12 7:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 14:47 [PATCH] net: bnx2x: convert to hw_features Michał Mirosław
2011-04-10 15:10 ` Vladislav Zolotarov
2011-04-10 15:23 ` Michał Mirosław
2011-04-10 15:35 ` [PATCH v2] " Michał Mirosław
2011-04-11 14:10 ` Vladislav Zolotarov
2011-04-11 19:54 ` [PATCH v3] " Michał Mirosław
2011-04-11 20:26 ` [PATCH v4] " Michał Mirosław
2011-04-12 12:10 ` Vladislav Zolotarov
2011-04-12 14:07 ` Michał Mirosław
2011-04-12 14:36 ` Vladislav Zolotarov
2011-04-12 14:49 ` Michał Mirosław
2011-04-12 19:38 ` [PATCH v5] " Michał Mirosław
2011-04-12 21:52 ` David Miller
2011-04-21 14:52 ` Eric Dumazet
2011-04-21 18:49 ` Vladislav Zolotarov
2011-04-21 19:19 ` Ben Hutchings
2011-04-21 22:15 ` Michał Mirosław
2011-04-21 22:52 ` Ben Hutchings
2011-04-21 23:12 ` [PATCH] net: fix hw_features ethtool_ops->set_flags compatibility Michał Mirosław
2011-04-21 23:19 ` [PATCH v2] " Michał Mirosław
2011-04-21 23:21 ` [PATCH v3] " Michał Mirosław
2011-04-21 23:59 ` [PATCH v4] " Michał Mirosław
2011-04-22 0:21 ` David Miller
2011-04-22 5:16 ` Eric Dumazet
2011-04-22 5:27 ` Eric Dumazet
2011-04-21 23:14 ` [PATCH v5] net: bnx2x: convert to hw_features Michał Mirosław
2011-04-21 23:44 ` Michał Mirosław
2011-04-21 22:41 ` Michał Mirosław
2011-04-21 22:42 ` [PATCH] net: make WARN_ON in dev_disable_lro() useful Michał Mirosław
2011-04-22 5:11 ` Eric Dumazet
2011-04-25 18:56 ` David Miller
2011-04-22 4:51 ` [PATCH v5] net: bnx2x: convert to hw_features Eric Dumazet
2011-04-13 9:36 ` [PATCH v4] " Vladislav Zolotarov
2011-04-11 20:12 ` [PATCH v2] " Michał Mirosław
2011-04-12 7:26 ` Vladislav Zolotarov
2011-04-12 7:46 ` Vladislav Zolotarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302594379.32697.33.camel@lb-tlvb-vladz \
--to=vladz@broadcom.com \
--cc=eilong@broadcom.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox