From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: make WARN_ON in dev_disable_lro() useful
Date: Fri, 22 Apr 2011 07:11:53 +0200 [thread overview]
Message-ID: <1303449113.13893.2.camel@edumazet-laptop> (raw)
In-Reply-To: <20110421224215.9B8AC13909@rere.qmqm.pl>
Le vendredi 22 avril 2011 à 00:42 +0200, Michał Mirosław a écrit :
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> net/core/dev.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 3871bf6..3421184 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1315,7 +1315,8 @@ void dev_disable_lro(struct net_device *dev)
> return;
>
> __ethtool_set_flags(dev, flags & ~ETH_FLAG_LRO);
> - WARN_ON(dev->features & NETIF_F_LRO);
> + if (unlikely(dev->features & NETIF_F_LRO))
> + netdev_WARN(dev, "failed to disable LRO!\n");
> }
> EXPORT_SYMBOL(dev_disable_lro);
>
Yes, as suggested one month ago
http://permalink.gmane.org/gmane.linux.network/189951
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
BTW, using unlikely() or likely() in slowpath is not exactly useful,
unless its integrated in macro (WARN_... )
next prev parent reply other threads:[~2011-04-22 5:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 14:47 [PATCH] net: bnx2x: convert to hw_features Michał Mirosław
2011-04-10 15:10 ` Vladislav Zolotarov
2011-04-10 15:23 ` Michał Mirosław
2011-04-10 15:35 ` [PATCH v2] " Michał Mirosław
2011-04-11 14:10 ` Vladislav Zolotarov
2011-04-11 19:54 ` [PATCH v3] " Michał Mirosław
2011-04-11 20:26 ` [PATCH v4] " Michał Mirosław
2011-04-12 12:10 ` Vladislav Zolotarov
2011-04-12 14:07 ` Michał Mirosław
2011-04-12 14:36 ` Vladislav Zolotarov
2011-04-12 14:49 ` Michał Mirosław
2011-04-12 19:38 ` [PATCH v5] " Michał Mirosław
2011-04-12 21:52 ` David Miller
2011-04-21 14:52 ` Eric Dumazet
2011-04-21 18:49 ` Vladislav Zolotarov
2011-04-21 19:19 ` Ben Hutchings
2011-04-21 22:15 ` Michał Mirosław
2011-04-21 22:52 ` Ben Hutchings
2011-04-21 23:12 ` [PATCH] net: fix hw_features ethtool_ops->set_flags compatibility Michał Mirosław
2011-04-21 23:19 ` [PATCH v2] " Michał Mirosław
2011-04-21 23:21 ` [PATCH v3] " Michał Mirosław
2011-04-21 23:59 ` [PATCH v4] " Michał Mirosław
2011-04-22 0:21 ` David Miller
2011-04-22 5:16 ` Eric Dumazet
2011-04-22 5:27 ` Eric Dumazet
2011-04-21 23:14 ` [PATCH v5] net: bnx2x: convert to hw_features Michał Mirosław
2011-04-21 23:44 ` Michał Mirosław
2011-04-21 22:41 ` Michał Mirosław
2011-04-21 22:42 ` [PATCH] net: make WARN_ON in dev_disable_lro() useful Michał Mirosław
2011-04-22 5:11 ` Eric Dumazet [this message]
2011-04-25 18:56 ` David Miller
2011-04-22 4:51 ` [PATCH v5] net: bnx2x: convert to hw_features Eric Dumazet
2011-04-13 9:36 ` [PATCH v4] " Vladislav Zolotarov
2011-04-11 20:12 ` [PATCH v2] " Michał Mirosław
2011-04-12 7:26 ` Vladislav Zolotarov
2011-04-12 7:46 ` Vladislav Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303449113.13893.2.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox