From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: mirqus@gmail.com, alex@alex.org.uk, netdev@vger.kernel.org,
jesse@nicira.com, paulmck@linux.vnet.ibm.com,
greearb@candelatech.com, Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-next-2.6] net: use batched device unregister in veth and macvlan
Date: Mon, 09 May 2011 22:17:31 +0200 [thread overview]
Message-ID: <1304972251.3050.11.camel@edumazet-laptop> (raw)
In-Reply-To: <1304967935.3050.9.camel@edumazet-laptop>
Le lundi 09 mai 2011 à 21:05 +0200, Eric Dumazet a écrit :
> BTW, bug must be present in net-2.6, if we unload vlan module (since in this
> case we also had a non NULL head )
Yes, I confirm we have the bug in linux-2.6
Here eth2 provided by tg3 module
ip link add link eth2 eth2.103 type vlan id 103 gvrp on loose_binding on
ip link add link eth2 eth2.104 type vlan id 104 gvrp on loose_binding on
ip link set eth2.103 up
ip link set eth2.104 up
sync
sleep 5
sync
rmmod tg3
<<<BUG>>>
[ 1848.669338] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 1848.669388] IP: [<ffffffffa0030c9e>] garp_request_leave+0x3e/0xc0 [garp]
[ 1848.669421] PGD 11d251067 PUD 11b9e0067 PMD 0
[ 1848.669454] Oops: 0000 [#1] SMP
[ 1848.669482] last sysfs file: /sys/devices/virtual/net/eth2.104/ifindex
[ 1848.669512] CPU 0
[ 1848.669518] Modules linked in: tg3(-) 8021q garp nfsd lockd auth_rpcgss sunrpc libphy sg [last unloaded: x_tables]
[ 1848.669613]
[ 1848.669633] Pid: 11494, comm: rmmod Tainted: G W 2.6.39-rc6-00261-gfd71257-dirty #580 HP ProLiant BL460c G6
[ 1848.669688] RIP: 0010:[<ffffffffa0030c9e>] [<ffffffffa0030c9e>] garp_request_leave+0x3e/0xc0 [garp]
[ 1848.669740] RSP: 0018:ffff88007a19bae8 EFLAGS: 00010286
[ 1848.669766] RAX: 0000000000000000 RBX: ffff88011b5e2000 RCX: 0000000000000002
[ 1848.669796] RDX: 0000000000000000 RSI: 0000000000000175 RDI: ffffffffa0030d5b
[ 1848.669826] RBP: ffff88007a19bb18 R08: 0000000000000001 R09: ffff88011bd64a00
[ 1848.669860] R10: ffff88011d34ec00 R11: 0000000000000000 R12: 0000000000000002
[ 1848.669890] R13: ffff88007a19bc48 R14: ffff88007a19bb88 R15: 0000000000000001
[ 1848.669920] FS: 0000000000000000(0000) GS:ffff88011fc00000(0063) knlGS:00000000f77d76c0
[ 1848.669966] CS: 0010 DS: 002b ES: 002b CR0: 000000008005003b
[ 1848.669993] CR2: 0000000000000000 CR3: 000000011a675000 CR4: 00000000000006f0
[ 1848.670023] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 1848.670063] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 1848.670115] Process rmmod (pid: 11494, threadinfo ffff88007a19a000, task ffff8800798595c0)
[ 1848.672098] Stack:
[ 1848.672118] ffff88007a19bb36 ffff88011c84b800 ffff88011b5e2000 ffff88007a19bc48
[ 1848.672172] ffff88007a19bb88 0000000000000006 ffff88007a19bb38 ffffffffa003a5f6
[ 1848.672235] ffff88007a19bb38 670088007a19bba8 ffff88007a19bb58 ffffffffa00397e7
[ 1848.672293] Call Trace:
[ 1848.672317] [<ffffffffa003a5f6>] vlan_gvrp_request_leave+0x46/0x50 [8021q]
[ 1848.672348] [<ffffffffa00397e7>] vlan_dev_stop+0xb7/0xc0 [8021q]
[ 1848.672377] [<ffffffff8137e427>] __dev_close_many+0x87/0xe0
[ 1848.672405] [<ffffffff8137e507>] dev_close_many+0x87/0x110
[ 1848.672433] [<ffffffff8137e630>] rollback_registered_many+0xa0/0x240
[ 1848.672462] [<ffffffff8137e7e9>] unregister_netdevice_many+0x19/0x60
[ 1848.672492] [<ffffffffa00389eb>] vlan_device_event+0x53b/0x550 [8021q]
[ 1848.672522] [<ffffffff8143f448>] ? ip6mr_device_event+0xa8/0xd0
[ 1848.672551] [<ffffffff81479d03>] notifier_call_chain+0x53/0x80
[ 1848.672583] [<ffffffff81062539>] __raw_notifier_call_chain+0x9/0x10
[ 1848.672612] [<ffffffff81062551>] raw_notifier_call_chain+0x11/0x20
[ 1848.672641] [<ffffffff8137df82>] call_netdevice_notifiers+0x32/0x60
[ 1848.672671] [<ffffffff8137e69f>] rollback_registered_many+0x10f/0x240
[ 1848.672700] [<ffffffff8137e85f>] rollback_registered+0x2f/0x40
[ 1848.672729] [<ffffffff8137e8c8>] unregister_netdevice_queue+0x58/0x90
[ 1848.672759] [<ffffffff8137e9eb>] unregister_netdev+0x1b/0x30
[ 1848.672788] [<ffffffffa005d73f>] tg3_remove_one+0x6f/0x10b [tg3]
next prev parent reply other threads:[~2011-05-09 20:17 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 11:08 Scalability of interface creation and deletion Alex Bligh
2011-05-07 12:22 ` Eric Dumazet
2011-05-07 15:26 ` Alex Bligh
2011-05-07 15:54 ` Eric Dumazet
2011-05-07 16:23 ` Ben Greear
2011-05-07 16:37 ` Eric Dumazet
2011-05-07 16:44 ` Ben Greear
2011-05-07 16:51 ` Eric Dumazet
2011-05-08 3:45 ` Ben Greear
2011-05-08 8:08 ` Alex Bligh
2011-05-09 21:46 ` Octavian Purdila
2011-05-07 16:26 ` Eric Dumazet
2011-05-07 18:24 ` Alex Bligh
2011-05-07 18:32 ` Eric Dumazet
2011-05-07 18:39 ` Eric Dumazet
2011-05-08 10:09 ` Alex Bligh
2011-05-07 18:42 ` Eric Dumazet
2011-05-07 18:50 ` Alex Bligh
2011-05-08 7:12 ` Eric Dumazet
2011-05-08 8:06 ` Alex Bligh
2011-05-08 9:35 ` Alex Bligh
2011-05-08 12:18 ` Alex Bligh
2011-05-08 12:50 ` Paul E. McKenney
2011-05-08 13:13 ` Alex Bligh
2011-05-08 13:44 ` Paul E. McKenney
2011-05-08 14:27 ` Alex Bligh
2011-05-08 14:47 ` Paul E. McKenney
2011-05-08 15:17 ` Alex Bligh
2011-05-08 15:48 ` Paul E. McKenney
2011-05-08 21:00 ` Eric Dumazet
2011-05-09 4:44 ` [PATCH] veth: use batched device unregister Eric Dumazet
2011-05-09 6:56 ` Michał Mirosław
2011-05-09 8:20 ` Eric Dumazet
2011-05-09 9:17 ` [PATCH net-next-2.6] net: use batched device unregister in veth and macvlan Eric Dumazet
2011-05-09 18:42 ` David Miller
2011-05-09 19:05 ` Eric Dumazet
2011-05-09 20:17 ` Eric Dumazet [this message]
2011-05-10 6:40 ` [PATCH net-2.6] vlan: fix GVRP at dismantle time Eric Dumazet
2011-05-10 19:23 ` David Miller
2011-05-09 7:45 ` [PATCH v2 net-next-2.6] veth: use batched device unregister Eric Dumazet
2011-05-09 9:22 ` Eric Dumazet
2011-05-09 5:37 ` Scalability of interface creation and deletion Alex Bligh
2011-05-09 6:37 ` Eric Dumazet
2011-05-09 7:11 ` Paul E. McKenney
2011-05-09 17:30 ` Jesse Gross
2011-05-08 12:44 ` Paul E. McKenney
2011-05-08 13:06 ` Alex Bligh
2011-05-08 13:14 ` Alex Bligh
2011-05-08 12:32 ` Paul E. McKenney
2011-05-07 18:51 ` Alex Bligh
2011-05-07 19:24 ` Eric Dumazet
2011-05-07 18:38 ` Alex Bligh
2011-05-07 18:44 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304972251.3050.11.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=alex@alex.org.uk \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=jesse@nicira.com \
--cc=kaber@trash.net \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox