Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
	Pantelis Antoniou <pantelis.antoniou@gmail.com>,
	Vitaly Bordug <vbordug@ru.mvista.com>
Subject: Re: [PATCH 07/11] fs_enet: enable transmit time stamping.
Date: Sun, 19 Jun 2011 13:58:04 +0200	[thread overview]
Message-ID: <1308484684.3539.76.camel@edumazet-laptop> (raw)
In-Reply-To: <2a8677b99c6b8d0e34bbf0f6d6a44e6c7992636d.1308481492.git.richard.cochran@omicron.at>

Le dimanche 19 juin 2011 à 13:20 +0200, Richard Cochran a écrit :
> This patch enables software (and phy device) transmit time stamping.
> Compile tested only.
> 
> Cc: Pantelis Antoniou <pantelis.antoniou@gmail.com>
> Cc: Vitaly Bordug <vbordug@ru.mvista.com>
> Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
> ---
>  drivers/net/fs_enet/fs_enet-main.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
> index 21abb5c..8dcb272 100644
> --- a/drivers/net/fs_enet/fs_enet-main.c
> +++ b/drivers/net/fs_enet/fs_enet-main.c
> @@ -701,6 +701,8 @@ static int fs_enet_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  
>  	spin_unlock_irqrestore(&fep->tx_lock, flags);
>  
> +	skb_tx_timestamp(skb);
> +
>  	return NETDEV_TX_OK;
>  }
>  

Well, I'll stop my review here, there is the same problem I guess in all
your patches.



  reply	other threads:[~2011-06-19 11:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-19 11:19 [PATCH 00/11] net: expand time stamping, batch #2 Richard Cochran
2011-06-19 11:19 ` [PATCH 01/11] net: export the receive time stamping hook for non-NAPI drivers Richard Cochran
2011-06-19 11:19 ` [PATCH 02/11] lib8390: enable transmit and receive time stamping Richard Cochran
2011-06-19 11:19 ` [PATCH 03/11] emaclite: " Richard Cochran
2011-06-19 11:53   ` Eric Dumazet
2011-06-19 11:20 ` [PATCH 04/11] ll_temac: " Richard Cochran
2011-06-19 11:20 ` [PATCH 05/11] fec_mpc52xx: " Richard Cochran
2011-06-19 11:56   ` Eric Dumazet
2011-06-19 11:20 ` [PATCH 06/11] macb: enable transmit " Richard Cochran
2011-06-19 11:56   ` Eric Dumazet
2011-06-19 11:20 ` [PATCH 07/11] fs_enet: " Richard Cochran
2011-06-19 11:58   ` Eric Dumazet [this message]
2011-06-19 18:12     ` Richard Cochran
2011-06-19 18:30       ` Eric Dumazet
2011-06-20  6:58         ` Richard Cochran
2011-06-22 23:56           ` Matt Carlson
2011-06-19 11:20 ` [PATCH 08/11] smsc911x: " Richard Cochran
2011-06-19 11:20 ` [PATCH 09/11] pxa168_eth: " Richard Cochran
2011-06-19 18:15   ` Richard Cochran
2011-06-19 11:20 ` [PATCH 10/11] mv643xx_eth: " Richard Cochran
2011-06-19 18:17   ` Richard Cochran
2011-06-19 18:33     ` Eric Dumazet
2011-06-19 19:05       ` David Miller
2011-06-19 22:43         ` [PATCH] hp100: fix an skb->len race Eric Dumazet
2011-06-19 23:34           ` David Miller
2011-06-19 11:20 ` [PATCH 11/11] ucc_geth: enable transmit time stamping Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308484684.3539.76.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pantelis.antoniou@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=vbordug@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox