From: Eric Dumazet <eric.dumazet@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH 10/11] mv643xx_eth: enable transmit time stamping.
Date: Sun, 19 Jun 2011 20:33:18 +0200 [thread overview]
Message-ID: <1308508398.3539.80.camel@edumazet-laptop> (raw)
In-Reply-To: <20110619181740.GC3594@riccoc20.at.omicron.at>
Le dimanche 19 juin 2011 à 20:17 +0200, Richard Cochran a écrit :
> On Sun, Jun 19, 2011 at 01:20:06PM +0200, Richard Cochran wrote:
> > This patch enables software (and phy device) transmit time stamping.
> > Compile tested only.
> >
> > Cc: Lennert Buytenhek <buytenh@wantstofly.org>
> > Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
> > ---
> > drivers/net/mv643xx_eth.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
> > index a5d9b1c..c7a8f10 100644
> > --- a/drivers/net/mv643xx_eth.c
> > +++ b/drivers/net/mv643xx_eth.c
> > @@ -884,6 +884,8 @@ static netdev_tx_t mv643xx_eth_xmit(struct sk_buff *skb, struct net_device *dev)
> > if (!txq_submit_skb(txq, skb)) {
> > int entries_left;
> >
> > + skb_tx_timestamp(skb);
> > +
> > txq->tx_bytes += skb->len;
>
> And the line above is unsafe, as well.
>
Yes, for sure, please submit patches to fix this (before adding time
stamping patches), as this should go to stable.
next prev parent reply other threads:[~2011-06-19 18:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 11:19 [PATCH 00/11] net: expand time stamping, batch #2 Richard Cochran
2011-06-19 11:19 ` [PATCH 01/11] net: export the receive time stamping hook for non-NAPI drivers Richard Cochran
2011-06-19 11:19 ` [PATCH 02/11] lib8390: enable transmit and receive time stamping Richard Cochran
2011-06-19 11:19 ` [PATCH 03/11] emaclite: " Richard Cochran
2011-06-19 11:53 ` Eric Dumazet
2011-06-19 11:20 ` [PATCH 04/11] ll_temac: " Richard Cochran
2011-06-19 11:20 ` [PATCH 05/11] fec_mpc52xx: " Richard Cochran
2011-06-19 11:56 ` Eric Dumazet
2011-06-19 11:20 ` [PATCH 06/11] macb: enable transmit " Richard Cochran
2011-06-19 11:56 ` Eric Dumazet
2011-06-19 11:20 ` [PATCH 07/11] fs_enet: " Richard Cochran
2011-06-19 11:58 ` Eric Dumazet
2011-06-19 18:12 ` Richard Cochran
2011-06-19 18:30 ` Eric Dumazet
2011-06-20 6:58 ` Richard Cochran
2011-06-22 23:56 ` Matt Carlson
2011-06-19 11:20 ` [PATCH 08/11] smsc911x: " Richard Cochran
2011-06-19 11:20 ` [PATCH 09/11] pxa168_eth: " Richard Cochran
2011-06-19 18:15 ` Richard Cochran
2011-06-19 11:20 ` [PATCH 10/11] mv643xx_eth: " Richard Cochran
2011-06-19 18:17 ` Richard Cochran
2011-06-19 18:33 ` Eric Dumazet [this message]
2011-06-19 19:05 ` David Miller
2011-06-19 22:43 ` [PATCH] hp100: fix an skb->len race Eric Dumazet
2011-06-19 23:34 ` David Miller
2011-06-19 11:20 ` [PATCH 11/11] ucc_geth: enable transmit time stamping Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308508398.3539.80.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox