From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexey Zaytsev <alexey.zaytsev@gmail.com>
Cc: "Michael Büsch" <m@bues.ch>,
"Andrew Morton" <akpm@linux-foundation.org>,
netdev@vger.kernel.org, "Gary Zambrano" <zambrano@broadcom.com>,
bugme-daemon@bugzilla.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Pekka Pietikainen" <pp@ee.oulu.fi>,
"Florian Schirmer" <jolt@tuxbox.org>,
"Felix Fietkau" <nbd@openwrt.org>,
"Michael Buesch" <mb@bu3sch.de>
Subject: Re: [Bugme-new] [Bug 38102] New: BUG kmalloc-2048: Poison overwritten
Date: Tue, 05 Jul 2011 07:10:42 +0200 [thread overview]
Message-ID: <1309842642.2720.36.camel@edumazet-laptop> (raw)
In-Reply-To: <CAB9v_DFM8PcujUB-YzcK49DS7T6Bz2FLDtkVdEYt8an1oPYVFw@mail.gmail.com>
Le mardi 05 juillet 2011 à 08:57 +0400, Alexey Zaytsev a écrit :
> Ran tcpdump. You are right, I was wrong. Sorry for the noise.
Thanks for testing ;)
It would be nice to know if the memory scribbles start after or before
one RFO triggers.
I can see this calls b44_init_rings() without really stopping the device
before. This seems very suspect to me.
diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index a69331e..b22dd4c 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
@@ -829,6 +829,7 @@ static int b44_rx(struct b44 *bp, int budget)
}
bp->rx_cons = cons;
+ wmb();
bw32(bp, B44_DMARX_PTR, cons * sizeof(struct dma_desc));
return received;
@@ -848,6 +849,7 @@ static int b44_poll(struct napi_struct *napi, int budget)
/* spin_unlock(&bp->tx_lock); */
}
if (bp->istat & ISTAT_RFO) { /* fast recovery, in ~20msec */
+ pr_err("b44: ISTAT_RFO !\n");
bp->istat &= ~ISTAT_RFO;
b44_disable_ints(bp);
ssb_device_enable(bp->sdev, 0); /* resets ISTAT_RFO */
next prev parent reply other threads:[~2011-07-05 5:10 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-38102-10286@https.bugzilla.kernel.org/>
2011-06-29 21:51 ` [Bugme-new] [Bug 38102] New: BUG kmalloc-2048: Poison overwritten Andrew Morton
2011-07-01 6:01 ` Alexey Zaytsev
2011-07-02 21:25 ` Alexey Zaytsev
2011-07-03 15:46 ` Eric Dumazet
2011-07-04 11:48 ` Alexey Zaytsev
2011-07-04 13:05 ` Michael Büsch
2011-07-04 13:57 ` Eric Dumazet
2011-07-04 14:27 ` Michael Büsch
2011-07-04 14:43 ` Michael Büsch
2011-07-04 14:53 ` Eric Dumazet
2011-07-04 15:12 ` Eric Dumazet
2011-07-04 20:25 ` Alexey Zaytsev
2011-07-04 22:29 ` Alexey Zaytsev
2011-07-05 3:44 ` Eric Dumazet
2011-07-05 3:56 ` Alexey Zaytsev
2011-07-05 4:11 ` Eric Dumazet
2011-07-05 4:14 ` Eric Dumazet
2011-07-05 4:17 ` Alexey Zaytsev
2011-07-05 4:18 ` Alexey Zaytsev
2011-07-05 4:25 ` Eric Dumazet
2011-07-05 4:29 ` Alexey Zaytsev
2011-07-05 4:38 ` Eric Dumazet
2011-07-05 4:57 ` Alexey Zaytsev
2011-07-05 5:10 ` Eric Dumazet [this message]
2011-07-05 5:18 ` Alexey Zaytsev
2011-07-05 5:33 ` Eric Dumazet
2011-07-05 5:59 ` Eric Dumazet
2011-07-05 16:05 ` Neil Horman
2011-07-05 16:12 ` Eric Dumazet
2011-07-05 16:27 ` Michael Büsch
2011-07-05 16:42 ` Neil Horman
2011-07-05 16:47 ` Eric Dumazet
2011-07-05 16:57 ` Eric Dumazet
2011-07-05 17:01 ` Joe Perches
2011-07-05 17:21 ` Neil Horman
2011-07-05 18:06 ` Neil Horman
2011-07-05 18:13 ` Eric Dumazet
2011-07-05 18:32 ` Eric Dumazet
2011-07-05 18:45 ` Eric Dumazet
2011-07-05 19:53 ` Neil Horman
2011-07-05 20:02 ` Eric Dumazet
2011-07-05 20:15 ` Eric Dumazet
2011-07-05 22:06 ` Neil Horman
2011-07-06 15:32 ` Michael Büsch
2011-07-06 16:00 ` Eric Dumazet
2011-07-06 16:12 ` Michael Büsch
2011-07-06 16:35 ` Eric Dumazet
2011-07-06 16:56 ` Eric Dumazet
2011-07-07 6:32 ` Alexey Zaytsev
2011-07-07 6:48 ` Eric Dumazet
2011-07-07 7:45 ` Alexey Zaytsev
2011-07-07 9:20 ` Eric Dumazet
2011-07-07 9:34 ` Alexey Zaytsev
2011-07-07 9:37 ` Alexey Zaytsev
2011-07-07 9:43 ` Alexey Zaytsev
2011-07-07 9:52 ` Eric Dumazet
2011-07-05 4:21 ` Eric Dumazet
2011-07-04 14:00 ` Eric Dumazet
2011-07-04 14:31 ` Michael Büsch
2011-07-04 14:45 ` Eric Dumazet
2011-07-04 14:51 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309842642.2720.36.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexey.zaytsev@gmail.com \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=jolt@tuxbox.org \
--cc=m@bues.ch \
--cc=mb@bu3sch.de \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=pp@ee.oulu.fi \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox