* [PATCH] bpfilter: document build requirements for bpfilter_umh
@ 2020-05-09 4:47 Valdis Klētnieks
2020-05-09 7:51 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Valdis Klētnieks @ 2020-05-09 4:47 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Sam Ravnborg, David S. Miller, Networking, bpf,
Linux Kernel Mailing List
It's not intuitively obvious that bpfilter_umh is a statically linked binary.
Mention the toolchain requirement in the Kconfig help, so people
have an easier time figuring out what's needed.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig
index fed9290e3b41..0ec6c7958c20 100644
--- a/net/bpfilter/Kconfig
+++ b/net/bpfilter/Kconfig
@@ -13,4 +13,8 @@ config BPFILTER_UMH
default m
help
This builds bpfilter kernel module with embedded user mode helper
+
+ Note: your toolchain must support building static binaries, since
+ rootfs isn't mounted at the time when __init functions are called
+ and do_execv won't be able to find the elf interpreter.
endif
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bpfilter: document build requirements for bpfilter_umh
2020-05-09 4:47 [PATCH] bpfilter: document build requirements for bpfilter_umh Valdis Klētnieks
@ 2020-05-09 7:51 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2020-05-09 7:51 UTC (permalink / raw)
To: Valdis Klētnieks
Cc: Sam Ravnborg, David S. Miller, Networking, bpf,
Linux Kernel Mailing List
On Sat, May 9, 2020 at 1:47 PM Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
>
> It's not intuitively obvious that bpfilter_umh is a statically linked binary.
> Mention the toolchain requirement in the Kconfig help, so people
> have an easier time figuring out what's needed.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>
Applied to linux-kbuild.
Thanks.
> diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig
> index fed9290e3b41..0ec6c7958c20 100644
> --- a/net/bpfilter/Kconfig
> +++ b/net/bpfilter/Kconfig
> @@ -13,4 +13,8 @@ config BPFILTER_UMH
> default m
> help
> This builds bpfilter kernel module with embedded user mode helper
> +
> + Note: your toolchain must support building static binaries, since
> + rootfs isn't mounted at the time when __init functions are called
> + and do_execv won't be able to find the elf interpreter.
> endif
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-09 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-09 4:47 [PATCH] bpfilter: document build requirements for bpfilter_umh Valdis Klētnieks
2020-05-09 7:51 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox