From: Joe Perches <joe@perches.com>
To: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Dept_NX_Linux_NIC_Driver <Dept_NX_Linux_NIC_Driver@qlogic.com>
Subject: Re: [PATCH net-next 2/2] qlcnic: Change CDRP function
Date: Tue, 13 Sep 2011 11:22:50 -0700 [thread overview]
Message-ID: <1315938171.25776.11.camel@Joe-Laptop> (raw)
In-Reply-To: <1315937179-22383-2-git-send-email-anirban.chakraborty@qlogic.com>
On Tue, 2011-09-13 at 11:06 -0700, Anirban Chakraborty wrote:
> Argument list to CDRP function has become unmanageably long. Fix it by properly
> declaring a struct that encompasses all the input and output parameters.
I don't think this is better.
I think you've overloaded the issue_cmd function and should
use separate issue_cmd_<type> functions instead.
next prev parent reply other threads:[~2011-09-13 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 18:06 [PATCH net-next 1/2] qlcnic: Added error logging for firmware abort Anirban Chakraborty
2011-09-13 18:06 ` [PATCH net-next 2/2] qlcnic: Change CDRP function Anirban Chakraborty
2011-09-13 18:22 ` Joe Perches [this message]
2011-09-13 20:28 ` Anirban Chakraborty
2011-09-13 20:56 ` Joe Perches
2011-09-13 21:15 ` Anirban Chakraborty
2011-09-13 18:06 ` [PATCH net-next 0/2] qlcnic: Fixes Anirban Chakraborty
2011-09-23 18:10 ` Anirban Chakraborty
2011-09-23 18:24 ` David Miller
2011-09-23 18:29 ` Anirban Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315938171.25776.11.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox