Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Taht <dave.taht@gmail.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
	"Yan, Zheng" <zheng.z.yan@intel.com>,
	"Herbert Xu" <herbert@gondor.hengli.com.au>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>
Subject: Re: [BUG?] tcp: potential bug in tcp_is_sackblock_valid()
Date: Sun, 18 Sep 2011 22:39:09 +0200	[thread overview]
Message-ID: <1316378349.31335.34.camel@edumazet-laptop> (raw)
In-Reply-To: <CAA93jw7L9KyXVevZ8dqE+ExLYP9=CLMmj1gPD88ihBuC6ZovOQ@mail.gmail.com>

Le samedi 17 septembre 2011 à 11:30 -0700, Dave Taht a écrit :

> 
> As cerowrt is one of the few projects enabling sack/dsack/ecn by
> default, it would be good to know either
> 

dsack is enabled by default on linux, not only cerowt project.

> A) how to test to see if this problem is really a problem
> B) should we apply the obvious fix

Isnt Cerowrt a router, most of frames are forwarded anyway ?

This bug is relevant to linux hosts, receiving Duplicate Sacks (RFC
2883).

  parent reply	other threads:[~2011-09-18 20:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-09  1:45 [BUG?] tcp: potential bug in tcp_is_sackblock_valid() Yan, Zheng
2011-09-09  1:54 ` Herbert Xu
2011-09-09  2:10   ` Yan, Zheng
2011-09-09  8:03     ` Ilpo Järvinen
     [not found]       ` <CAA93jw7L9KyXVevZ8dqE+ExLYP9=CLMmj1gPD88ihBuC6ZovOQ@mail.gmail.com>
2011-09-18 20:39         ` Eric Dumazet [this message]
2011-09-18 21:04           ` Dave Taht
2011-09-18 21:20             ` Hagen Paul Pfeifer
2011-09-18 19:35 ` Eric Dumazet
2011-09-19  1:07   ` David Miller
2011-09-19  2:05     ` [PATCH] tcp: fix validation of D-SACK Yan, Zheng
2011-09-19  2:37       ` David Miller
2011-09-19 17:29         ` Jan Ceuleers
2011-09-20 18:50           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316378349.31335.34.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=dave.taht@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=zheng.z.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox