Netdev List
 help / color / mirror / Atom feed
* RE: [RFC/PATCH] net: add deferred flow cache flush function to be
@ 2011-09-26 16:58 Madalin Bucur
  0 siblings, 0 replies; only message in thread
From: Madalin Bucur @ 2011-09-26 16:58 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev, davem, timo.teras, Madalin Bucur

I've investigated this issue further and come up with a different fix -
modify the flow_cache_flush to prevent it from sleeping and also remove the
deferral of the actual gc work through schedule_work. That caused the gc never
to happen on a highly loaded system that had the cpus occupied servicing
network softirqs.

During the investigation I've also found two places the return value of 
dst_alloc was used without checking, leading to a crash. 

The 3 patches will follow.


> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On 
> Behalf Of Eric Dumazet
>
> Problem is sometime we dont want to defer and are in process context.
> 
> xfrm_dev_event(  event == NETDEV_DOWN) is probably a place we dont want
> to defer the garbage collection.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-09-26 16:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-26 16:58 [RFC/PATCH] net: add deferred flow cache flush function to be Madalin Bucur

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox