Netdev List
 help / color / mirror / Atom feed
From: Daniel Baluta <dbaluta@ixiacom.com>
To: davem@davemloft.net
Cc: eric.dumazet@gmail.com, gregory.v.rose@intel.com,
	jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
	Daniel Baluta <daniel.baluta@gmail.com>,
	Daniel Baluta <dbaluta@ixiacom.com>
Subject: [PATCH] neigh: print nud_state in neigh timer handler.
Date: Mon, 31 Oct 2011 23:10:48 +0200	[thread overview]
Message-ID: <1320095448-5228-1-git-send-email-dbaluta@ixiacom.com> (raw)

From: Daniel Baluta <daniel.baluta@gmail.com>

For debugging purposes it is useful to know the exact state of a
non NUD_IN_TIMER neighbour entry whose timer handler just expired.

Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>
---
 net/core/neighbour.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 909ecb3..6a8a311 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -874,7 +874,7 @@ static void neigh_timer_handler(unsigned long arg)
 
 	if (!(state & NUD_IN_TIMER)) {
 #ifndef CONFIG_SMP
-		printk(KERN_WARNING "neigh: timer & !nud_in_timer\n");
+		printk(KERN_WARNING "neigh: timer & !nud_in_timer, state:0x%x\n", state);
 #endif
 		goto out;
 	}
-- 
1.7.1

             reply	other threads:[~2011-10-31 21:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 21:10 Daniel Baluta [this message]
2011-11-01 21:44 ` [PATCH] neigh: print nud_state in neigh timer handler David Miller
2011-11-01 22:05   ` Daniel Baluta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320095448-5228-1-git-send-email-dbaluta@ixiacom.com \
    --to=dbaluta@ixiacom.com \
    --cc=daniel.baluta@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=gregory.v.rose@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox