Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dbaluta@ixiacom.com
Cc: eric.dumazet@gmail.com, gregory.v.rose@intel.com,
	jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
	daniel.baluta@gmail.com
Subject: Re: [PATCH] neigh: print nud_state in neigh timer handler.
Date: Tue, 01 Nov 2011 17:44:11 -0400 (EDT)	[thread overview]
Message-ID: <20111101.174411.1200019350687608200.davem@davemloft.net> (raw)
In-Reply-To: <1320095448-5228-1-git-send-email-dbaluta@ixiacom.com>

From: Daniel Baluta <dbaluta@ixiacom.com>
Date: Mon, 31 Oct 2011 23:10:48 +0200

> From: Daniel Baluta <daniel.baluta@gmail.com>
> 
> For debugging purposes it is useful to know the exact state of a
> non NUD_IN_TIMER neighbour entry whose timer handler just expired.
> 
> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>

This debugging log message is dubious.

Also, it is protected by !SMP and I can almost guarentee you that whatever
condition makes it happen leigitmately on SMP also can be triggered with
preemption enabled on !SMP.

So I'm going to simply remove this debug message entirely instead.

  reply	other threads:[~2011-11-01 21:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 21:10 [PATCH] neigh: print nud_state in neigh timer handler Daniel Baluta
2011-11-01 21:44 ` David Miller [this message]
2011-11-01 22:05   ` Daniel Baluta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111101.174411.1200019350687608200.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=daniel.baluta@gmail.com \
    --cc=dbaluta@ixiacom.com \
    --cc=eric.dumazet@gmail.com \
    --cc=gregory.v.rose@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox