Netdev List
 help / color / mirror / Atom feed
* [PATCH] net/ll_temac: FIX : Wait for indirect wait to end
@ 2011-11-08  9:39 Ricardo Ribalda Delgado
  2011-11-09 20:40 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Ribalda Delgado @ 2011-11-08  9:39 UTC (permalink / raw)
  To: davem, ian.campbell, eric.dumazet, jeffrey.t.kirsher, jpirko,
	netdev, linux-kernel
  Cc: Ricardo Ribalda Delgado

While tracing down a connectivity problem on the temac I connected a
probe to the Cross bar irq, and it was triggered when doing
ifdown->ifup.

This is fixed once waiting for the indirect write to end. Since it is
not on the hot path there is no performance loss.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/net/ethernet/xilinx/ll_temac_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 4d1658e..cf59dac 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -114,6 +114,7 @@ void temac_indirect_out32(struct temac_local *lp, int reg, u32 value)
 		return;
 	temac_iow(lp, XTE_LSW0_OFFSET, value);
 	temac_iow(lp, XTE_CTL0_OFFSET, CNTLREG_WRITE_ENABLE_MASK | reg);
+	temac_indirect_busywait(lp);
 }
 
 /**
-- 
1.7.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-09 20:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-08  9:39 [PATCH] net/ll_temac: FIX : Wait for indirect wait to end Ricardo Ribalda Delgado
2011-11-09 20:40 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox