* Re: config NET_ETHERNET
[not found] ` <20111109.001540.816179448716894786.davem@davemloft.net>
@ 2011-11-09 9:28 ` Jeff Kirsher
0 siblings, 0 replies; only message in thread
From: Jeff Kirsher @ 2011-11-09 9:28 UTC (permalink / raw)
To: David Miller; +Cc: pebolle@tiscali.nl, netdev
[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]
On Tue, 2011-11-08 at 21:15 -0800, David Miller wrote:
> From: Paul Bolle <pebolle@tiscali.nl>
> Date: Wed, 09 Nov 2011 01:41:15 +0100
>
> > 0) The Kconfig symbol NET_ETHERNET got dropped in commit f860b0522f
> > ("drivers/net: Kconfig and Makefile cleanup").
> >
> > 1) However, there are still a number of references to that symbol
> and to
> > the macro CONFIG_NET_ETHERNET:
> > $ git grep -n "NET_ETHERNET\>" | grep -v defconfig:
> > arch/cris/arch-v10/drivers/Kconfig:6: select NET_ETHERNET
> > arch/cris/arch-v32/drivers/Kconfig:6: select NET_ETHERNET
> > drivers/s390/net/Kconfig:7: depends on CCW && NETDEVICES
> && (NET_ETHERNET || TR || FDDI)
> > drivers/s390/net/lcs.c:53:#if !defined(CONFIG_NET_ETHERNET) && \
> > drivers/s390/net/lcs.c:1637:#ifdef CONFIG_NET_ETHERNET
> > drivers/s390/net/lcs.c:2169:#ifdef CONFIG_NET_ETHERNET
> >
> > 2) It's trivial to draft a patch which drops both that Kconfig
> symbol
> > and the macro (and everything that could be considered dead code by
> > now). But perhaps this needs a more sophisticated solution.
>
> The best thing to do for now is to switch these references over
> to use just plain "ETHERNET" and that's what I'll commit into
> the net tree.
>
> --------------------
> [PATCH] net: Fix references to deleted NET_ETHERNET Kconfig setting.
>
> Change them over to plain "ETHERNET"
>
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> arch/cris/arch-v10/drivers/Kconfig | 2 +-
> arch/cris/arch-v32/drivers/Kconfig | 2 +-
> drivers/s390/net/Kconfig | 2 +-
> drivers/s390/net/lcs.c | 6 +++---
> 4 files changed, 6 insertions(+), 6 deletions(-)
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] only message in thread