From: Eric Dumazet <eric.dumazet@gmail.com>
To: igorm@etf.rs
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] netstamp_needed shouldn't be jump_label_key
Date: Mon, 28 Nov 2011 21:33:46 +0100 [thread overview]
Message-ID: <1322512426.2970.15.camel@edumazet-laptop> (raw)
In-Reply-To: <1322511796-6908-2-git-send-email-igorm@etf.rs>
Le lundi 28 novembre 2011 à 21:23 +0100, igorm@etf.rs a écrit :
> From: Igor Maravic <igorm@etf.rs>
>
> Problem with setting netstamp_needed as jump_label_key is that
> it inc/dec, functions net_enable_timestamp/net_disable_timestamp,
> are called from interrupts.
>
> That can cause DEADLOCK, because jump_label_{inc, dec} are using mutex locking,
> that may sleep.
>
> Signed-off-by: Igor Maravic <igorm@etf.rs>
>
Come on, we can find another way to handle this :)
Its net-next, we are allowed to try to find something better.
next prev parent reply other threads:[~2011-11-28 20:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 20:23 [PATCH 0/1] jump_label logic fixing in dev.c igorm
2011-11-28 20:23 ` [PATCH 1/1] netstamp_needed shouldn't be jump_label_key igorm
2011-11-28 20:33 ` Eric Dumazet [this message]
2011-11-28 21:16 ` Eric Dumazet
2011-11-28 21:31 ` Stephen Hemminger
2011-11-28 21:45 ` Eric Dumazet
2011-11-28 22:23 ` Eric Dumazet
2011-11-29 6:22 ` David Miller
2011-11-29 9:03 ` "Igor Maravić"
2011-11-29 9:31 ` Eric Dumazet
2011-11-29 9:48 ` "Igor Maravić"
2011-11-29 10:27 ` Eric Dumazet
2011-11-29 10:32 ` Igor Maravić
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322512426.2970.15.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=igorm@etf.rs \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox