Re: [PATCH 1/1] netstamp_needed shouldn't be jump_label_key

[Eric Dumazet <eric.dumazet@gmail.com>]

Le lundi 28 novembre 2011 à 22:16 +0100, Eric Dumazet a écrit :

> [PATCH net-next] net: dont call jump_label_dec from irq context
> 
> Igor Maravic reported an error caused by jump_label_dec() being called
> from IRQ context :

> ...

> Since jump_label_{inc|dec} must be called from process context only,
> we must defer jump_label_dec() if net_disable_timestamp() is called
> from interrupt context.
> 
> Reported-by: Igor Maravic <igorm@etf.rs>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
>  net/core/dev.c                 |   23 +++++++++++++++++++++++
>  net/ipv4/netfilter/ip_queue.c  |    6 ++++--
>  net/ipv6/netfilter/ip6_queue.c |    5 ++++-
>  3 files changed, 31 insertions(+), 3 deletions(-)

By the way, we also can call sock_disable_timestamp() from sk_free()
instead of calling it from __sk_free()

This makes no sense to wait that all in-flight packets were destroyed
before removing sk timestamping.