* [PATCH net] netprio_cgroup.h: dont include module.h from other includes
@ 2012-01-24 21:33 Paul Gortmaker
2012-01-24 21:42 ` David Miller
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Paul Gortmaker @ 2012-01-24 21:33 UTC (permalink / raw)
To: nhorman, davem; +Cc: netdev, jdb, eric.dumazet, Paul Gortmaker
A considerable effort was invested in wiping out module.h
from being present in all the other standard includes. This
one leaked back in, but once again isn't strictly necessary,
so remove it.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[x86-64 modconfig, yesconfig and ppc64 defconfig all build OK]
diff --git a/include/net/netprio_cgroup.h b/include/net/netprio_cgroup.h
index e503b87..7b2d431 100644
--- a/include/net/netprio_cgroup.h
+++ b/include/net/netprio_cgroup.h
@@ -13,7 +13,6 @@
#ifndef _NETPRIO_CGROUP_H
#define _NETPRIO_CGROUP_H
-#include <linux/module.h>
#include <linux/cgroup.h>
#include <linux/hardirq.h>
#include <linux/rcupdate.h>
--
1.7.7.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] netprio_cgroup.h: dont include module.h from other includes
2012-01-24 21:33 [PATCH net] netprio_cgroup.h: dont include module.h from other includes Paul Gortmaker
@ 2012-01-24 21:42 ` David Miller
2012-01-24 22:04 ` Eric Dumazet
2012-01-25 11:59 ` Neil Horman
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-01-24 21:42 UTC (permalink / raw)
To: paul.gortmaker; +Cc: nhorman, netdev, jdb, eric.dumazet
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Tue, 24 Jan 2012 16:33:19 -0500
> A considerable effort was invested in wiping out module.h
> from being present in all the other standard includes. This
> one leaked back in, but once again isn't strictly necessary,
> so remove it.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> ---
>
> [x86-64 modconfig, yesconfig and ppc64 defconfig all build OK]
Applied, thanks Paul.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] netprio_cgroup.h: dont include module.h from other includes
2012-01-24 21:33 [PATCH net] netprio_cgroup.h: dont include module.h from other includes Paul Gortmaker
2012-01-24 21:42 ` David Miller
@ 2012-01-24 22:04 ` Eric Dumazet
2012-01-25 11:59 ` Neil Horman
2 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2012-01-24 22:04 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: nhorman, davem, netdev, jdb
Le mardi 24 janvier 2012 à 16:33 -0500, Paul Gortmaker a écrit :
> A considerable effort was invested in wiping out module.h
> from being present in all the other standard includes. This
> one leaked back in, but once again isn't strictly necessary,
> so remove it.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] netprio_cgroup.h: dont include module.h from other includes
2012-01-24 21:33 [PATCH net] netprio_cgroup.h: dont include module.h from other includes Paul Gortmaker
2012-01-24 21:42 ` David Miller
2012-01-24 22:04 ` Eric Dumazet
@ 2012-01-25 11:59 ` Neil Horman
2 siblings, 0 replies; 4+ messages in thread
From: Neil Horman @ 2012-01-25 11:59 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: davem, netdev, jdb, eric.dumazet
On Tue, Jan 24, 2012 at 04:33:19PM -0500, Paul Gortmaker wrote:
> A considerable effort was invested in wiping out module.h
> from being present in all the other standard includes. This
> one leaked back in, but once again isn't strictly necessary,
> so remove it.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> ---
>
> [x86-64 modconfig, yesconfig and ppc64 defconfig all build OK]
>
> diff --git a/include/net/netprio_cgroup.h b/include/net/netprio_cgroup.h
> index e503b87..7b2d431 100644
> --- a/include/net/netprio_cgroup.h
> +++ b/include/net/netprio_cgroup.h
> @@ -13,7 +13,6 @@
>
> #ifndef _NETPRIO_CGROUP_H
> #define _NETPRIO_CGROUP_H
> -#include <linux/module.h>
> #include <linux/cgroup.h>
> #include <linux/hardirq.h>
> #include <linux/rcupdate.h>
> --
> 1.7.7.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-25 11:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-24 21:33 [PATCH net] netprio_cgroup.h: dont include module.h from other includes Paul Gortmaker
2012-01-24 21:42 ` David Miller
2012-01-24 22:04 ` Eric Dumazet
2012-01-25 11:59 ` Neil Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox