From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: David Miller <davem@davemloft.net>,
bhutchings@solarflare.com, netdev@vger.kernel.org,
alekcejk@googlemail.com
Subject: Re: limited network bandwidth with 3.2.x kernels
Date: Thu, 16 Feb 2012 19:22:03 +0100 [thread overview]
Message-ID: <1329416523.2645.7.camel@edumazet-laptop> (raw)
In-Reply-To: <CADVnQykm==YJZbdCbLxgJ236jD2yN0xT99gmeYX-FGnyBvfEGA@mail.gmail.com>
Le jeudi 16 février 2012 à 12:22 -0500, Neal Cardwell a écrit :
> Our team has also run into issues with GRO/LRO "stretch ACKs", and
> their negative impact on TCP performance. We have a patch that we've
> been working with that deals with the sender-side issues. It turns out
> that neither the ABC nor non-ABC byte counting quite fixes the stretch
> ACKs issues.
>
> On the receiver side, the approach of changing tcp_grow_window() and
> __tcp_grow_window() to adjust things in terms of actual packet size
> rather than a fixed 2*MSS sounds great to me as well.
>
> In terms of the original 3.1 vs 3.2 issue report that started this
> thread, I didn't see any evidence of LRO or GRO causing stretch ACKs.
> (Alexey, would you be able to confim by running "ethtool -k eth0" on
> both kernels?) So it seems that probably the original issue is
> unrelated to stretch ACKs?
>
I do believe the "3.1 vs 3.2" issue is a matter of how skb truesize
fixes uncover prior bugs in tcp stack. Some drivers were lying about skb
truesize in hope to avoid these bugs...
For instance, I think we dont open receiver window fast enough in this
case, (and we probably enter the slow __tcp_grow_window() path)
On sender side, there are also issues, because if I have TSO on or off
on my 'netem delay 50ms' machine, performance is completely different.
It might have something to do with BQL. More testings needed.
next prev parent reply other threads:[~2012-02-16 18:22 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 20:04 limited network bandwidth with 3.2.x kernels alekcejk
2012-02-13 20:18 ` Eric Dumazet
2012-02-13 21:13 ` Eric Dumazet
2012-02-13 21:58 ` alekcejk
2012-02-13 22:44 ` Eric Dumazet
2012-02-13 22:51 ` Neal Cardwell
2012-02-13 23:09 ` alekcejk
2012-02-13 23:14 ` Eric Dumazet
2012-02-13 23:24 ` alekcejk
2012-02-13 23:49 ` alekcejk
2012-02-14 3:06 ` Neal Cardwell
2012-02-14 3:26 ` alekcejk
2012-02-14 5:55 ` Eric Dumazet
2012-02-14 14:09 ` alekcejk
2012-02-13 21:16 ` alekcejk
2012-02-21 4:21 ` alekcejk
2012-02-21 16:45 ` Eric Dumazet
2012-02-21 17:19 ` alekcejk
2012-02-21 17:31 ` Eric Dumazet
2012-02-21 18:53 ` alekcejk
2012-02-22 1:26 ` alekcejk
[not found] ` <1920135.kl3o7Tt79c@localhost.localdomain>
[not found] ` <1329228798.4818.0.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
2012-02-14 14:28 ` alekcejk
2012-02-14 16:00 ` Eric Dumazet
2012-02-14 16:43 ` alekcejk
2012-02-15 4:43 ` Eric Dumazet
2012-02-15 6:03 ` Neal Cardwell
2012-02-15 6:06 ` Eric Dumazet
2012-02-15 7:52 ` Bill Fink
2012-02-15 8:00 ` Eric Dumazet
2012-02-15 8:18 ` Bill Fink
2012-02-15 8:31 ` Eric Dumazet
2012-02-15 13:44 ` alekcejk
2012-02-15 13:43 ` Re: Re: Re: Re: " alekcejk
2012-02-15 13:44 ` alekcejk
2012-02-15 13:49 ` Eric Dumazet
2012-02-15 13:53 ` Eric Dumazet
2012-02-15 14:11 ` alekcejk
2012-02-15 14:49 ` Neal Cardwell
2012-02-15 14:56 ` Eric Dumazet
2012-02-15 15:05 ` alekcejk
2012-02-15 15:08 ` Eric Dumazet
2012-02-15 19:44 ` Neal Cardwell
2012-02-16 7:29 ` Eric Dumazet
2012-02-16 13:40 ` Eric Dumazet
2012-02-16 13:51 ` Ben Hutchings
2012-02-16 15:09 ` Eric Dumazet
2012-02-16 16:37 ` Ben Hutchings
2012-02-16 17:01 ` David Miller
2012-02-16 17:22 ` Neal Cardwell
2012-02-16 17:54 ` alekcejk
2012-02-16 18:19 ` Neal Cardwell
2012-02-16 21:49 ` alekcejk
2012-02-16 21:59 ` Eric Dumazet
2012-02-16 22:08 ` alekcejk
2012-02-16 22:35 ` Eric Dumazet
2012-02-17 16:41 ` Neal Cardwell
2012-02-21 18:41 ` Eric Dumazet
2012-02-21 19:11 ` David Miller
2012-02-22 5:51 ` Neal Cardwell
2012-02-22 7:36 ` Eric Dumazet
2012-02-23 18:39 ` Neal Cardwell
2012-02-23 18:49 ` Eric Dumazet
2012-02-27 19:39 ` David Miller
2012-02-17 16:55 ` Re: " Neal Cardwell
2012-02-16 18:22 ` Eric Dumazet [this message]
2012-02-16 19:44 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329416523.2645.7.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=alekcejk@googlemail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox