From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, netdev@vger.kernel.org
Subject: Re: 3.3-rc3+ Crash in __neigh_for_each_release
Date: Tue, 21 Feb 2012 20:15:56 +0100 [thread overview]
Message-ID: <1329851756.18384.47.camel@edumazet-laptop> (raw)
In-Reply-To: <20120221.140716.1396286389544946379.davem@davemloft.net>
Le mardi 21 février 2012 à 14:07 -0500, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 21 Feb 2012 20:03:24 +0100
>
> > But I dont know enough this code to know if the following patch is the
> > way to fix this. (and __neigh_for_each_release() can also be deleted if
> > no users left in tree)
>
> I think instead of removing the code, we need to have it iterate over
> "arp_tbl" but only invoke the callback for devices which are of type
> ATM.
That makes sense...
Or invoke callback for all entries, and filter in callback non ATM ones.
next prev parent reply other threads:[~2012-02-21 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 12:02 3.3-rc3+ Crash in __neigh_for_each_release Meelis Roos
2012-02-20 12:04 ` Meelis Roos
2012-02-21 19:03 ` Eric Dumazet
2012-02-21 19:07 ` David Miller
2012-02-21 19:15 ` Eric Dumazet [this message]
2012-02-21 20:46 ` Eric Dumazet
2012-02-21 22:46 ` David Miller
2012-02-22 7:19 ` mroos
2012-02-22 7:21 ` Eric Dumazet
2012-02-22 7:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329851756.18384.47.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox