Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: mroos@linux.ee
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: 3.3-rc3+ Crash in __neigh_for_each_release
Date: Wed, 22 Feb 2012 08:21:33 +0100	[thread overview]
Message-ID: <1329895293.18384.74.camel@edumazet-laptop> (raw)
In-Reply-To: <alpine.SOC.1.00.1202220918220.21339@math.ut.ee>

Le mercredi 22 février 2012 à 09:19 +0200, mroos@linux.ee a écrit :
> > What about following patch ?
> > 
> > Meelis, can you test it please ?
> 
> Works fine, thank you!
>  
> > [PATCH] atm: clip: remove clip_tbl
> > 
> > Commit 32092ecf0644 (atm: clip: Use device neigh support on top of
> > "arp_tbl".) introduced a bug since clip_tbl is zeroed : Crash occurs in
> > __neigh_for_each_release()
> > 
> > idle_timer_check() must use instead arp_tbl and neigh_check_cb() should
> > ignore non clip neighbours.
> > 
> > Idea from David Miller.
> > 
> > Reported-by: Meelis Roos <mroos@linux.ee>
> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> 
> Tested-by: Meelis Roos <mroos@linux.ee>
> 

Thanks !

  reply	other threads:[~2012-02-22  7:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20 12:02 3.3-rc3+ Crash in __neigh_for_each_release Meelis Roos
2012-02-20 12:04 ` Meelis Roos
2012-02-21 19:03 ` Eric Dumazet
2012-02-21 19:07   ` David Miller
2012-02-21 19:15     ` Eric Dumazet
2012-02-21 20:46       ` Eric Dumazet
2012-02-21 22:46         ` David Miller
2012-02-22  7:19         ` mroos
2012-02-22  7:21           ` Eric Dumazet [this message]
2012-02-22  7:24           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329895293.18384.74.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=mroos@linux.ee \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox