From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: yevgenyp@mellanox.co.il, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] mlx4_en: TX ring size default to 1024
Date: Thu, 23 Feb 2012 20:54:04 +0100 [thread overview]
Message-ID: <1330026844.15610.37.camel@edumazet-laptop> (raw)
In-Reply-To: <20120223.144541.1354349294973443529.davem@davemloft.net>
Le jeudi 23 février 2012 à 14:45 -0500, David Miller a écrit :
> From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
> Date: Thu, 23 Feb 2012 15:34:05 +0200
>
> > Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
>
> This is rediculious as a default, yes even for 10Gb.
>
> Do you have any idea how high latency is going to be for packets
> trying to get into the transmit queue if there are already a
> thousand other frames in there?
Before increasing TX ring sizes, a driver should implement BQL as a
prereq.
next prev parent reply other threads:[~2012-02-23 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 13:34 [PATCH net-next 1/3] mlx4_en: TX ring size default to 1024 Yevgeny Petrilin
2012-02-23 19:45 ` David Miller
2012-02-23 19:54 ` Eric Dumazet [this message]
2012-02-24 19:35 ` Yevgeny Petrilin
2012-02-24 20:14 ` David Miller
2012-02-24 20:17 ` Eric Dumazet
2012-02-25 6:51 ` Bill Fink
2012-02-25 8:22 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330026844.15610.37.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox