public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Yevgeny Petrilin <yevgenyp@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next 1/3] mlx4_en: TX ring size default to 1024
Date: Fri, 24 Feb 2012 19:35:45 +0000	[thread overview]
Message-ID: <953B660C027164448AE903364AC447D2618B8768@MTLDAG02.mtl.com> (raw)
In-Reply-To: <20120223.144541.1354349294973443529.davem@davemloft.net>

> > Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
> 
> This is rediculious as a default, yes even for 10Gb.
> 
> Do you have any idea how high latency is going to be for packets
> trying to get into the transmit queue if there are already a
> thousand other frames in there?

On the other hand, when having smaller queue with 1000 in-flight packets would mean queue would be stopped,
how is it better?
Having bigger TX ring helps dealing better with bursts of TX packets, without the overhead of stopping and starting the queue,
It also makes sense to have same size TX and RX queues, for example in case of traffic being forwarded from TX to RX.

I did find number of 10Gb vendors that have 1024 or more as the default size for TX queue.

Thanks,
Yevgeny

  parent reply	other threads:[~2012-02-24 19:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23 13:34 [PATCH net-next 1/3] mlx4_en: TX ring size default to 1024 Yevgeny Petrilin
2012-02-23 19:45 ` David Miller
2012-02-23 19:54   ` Eric Dumazet
2012-02-24 19:35   ` Yevgeny Petrilin [this message]
2012-02-24 20:14     ` David Miller
2012-02-24 20:17     ` Eric Dumazet
2012-02-25  6:51       ` Bill Fink
2012-02-25  8:22         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=953B660C027164448AE903364AC447D2618B8768@MTLDAG02.mtl.com \
    --to=yevgenyp@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox